bugQuilt - Bugs: bug #15716, backup-files usage fails on win32...

 
 

bug #15716: backup-files usage fails on win32 with -L option

Submitted by:  None
Submitted on:  Sat 11 Feb 2006 11:26:41 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 12 Feb 2006 12:01:27 AM UTC, comment #1:

Can't we just drop this stupid OS and use something decent and POSIX compliant instead?

I'm committing the fix to CVS.

Andreas Gruenbacher <agruen>
Project Administrator
Sat 11 Feb 2006 11:26:41 PM UTC, original submission:

On win32, you can't rename a file on top of an open file, so backup-files -L fails and leaves a hard-linked source and dest file -- causing me much head-scratching because quilt kept not finding any diffs in files I'd just add'd and changed (add kept failing with a 'permission denied' error, but the backup files seemed to be there).

The attached patch fixes this; it just closes both fds before doing the rename().

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1985:  quilt-win32-rename.patch added by None (793B - application/octet-stream - quilt-win32-rename.patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sun 12 Feb 2006 12:01:27 AM UTCagruenStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Sat 11 Feb 2006 11:26:41 PM UTCNoneAttached File-=>Added quilt-win32-rename.patch, #3391

Back to the top


Powered by Savane 3.1-cleanup1