bugGlobulation 2 - Bugs: bug #16023, Odd buttons on campaign and...

 
 

bug #16023: Odd buttons on campaign and tutorial screen

Submitted by:  Kieran <k776>
Submitted on:  Tue 07 Mar 2006 07:07:01 AM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Kevin Clement <donkyhotay>Open/Closed: Closed
Release: NoneOperating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 08 Mar 2006 03:30:26 AM UTC, comment #8:

I made the changes you posted and uploaded onto CVS for you.

Kevin Clement <donkyhotay>
Project MemberIn charge of this item.
Tue 07 Mar 2006 09:53:41 PM UTC, comment #7:

I just did that and confirmed the problem you described, should have downloaded from CVS awhile ago but I was originally just looking for a new RTS game for linux and it wasn't until I had spent a few hours fixing a bug that was annoying me that I realized that I might as well become a member and help out. I had spent so much time using the original source code from the downloads page I completely forgot that I didn't get it from CVS.

Kevin Clement <donkyhotay>
Project MemberIn charge of this item.
Tue 07 Mar 2006 09:30:27 PM UTC, comment #6:

"just ran glob2 on my winXP system and didn't have any problems. Reading through what you posted along with the source in campaignscreen.cpp I found that I have different code. I've simply been editing what I downloaded off the website when I first downloaded/compild the game (no current RPM's for fedora yet) and didn't go through CVS. There is no cancel button only a start button on this version so there isn't anything to conflict. I obviously need to get some updated code from CVS."

Ok. I suggest that you download and compile cvs code before making changes, incase something has changed since the release on the website. For eg, code for the networking has changed in places since the release, so the localhost bug you working on might be invalid or not work on cvs code.

Anyway, the post I made below works perfectly. I just need someone to submit it to CVS (nct said something about me checking out as anoncvs instead of my savannah user.... must read up about that and see if I can get it to commit).

Kieran <k776>
Project Administrator
Tue 07 Mar 2006 09:26:02 PM UTC, comment #5:

Nope. Its not a win32 bug. With a fresh install of glob2's cvs on mandriva linux, I get the same result. Btw, I made a mistake in the fix. Heres the correct instuctions (it fixes mandriva problem too):

Open src/CampaignScreen.cpp, find:

addWidget(new TextButton(20, 55, 70, 25, ALIGN_RIGHT, ALIGN_BOTTOM, "", -1, -1, "standard", Toolkit::getStringTable()->getString("[Start]"), 0, '\r'));

addWidget(new TextButton(20, 20, 70, 25, ALIGN_RIGHT, ALIGN_BOTTOM, "", -1, -1, "standard", Toolkit::getStringTable()->getString("[Cancel]"), 1, 27));

And replace with:

addWidget(new TextButton(20, 20, 70, 25, ALIGN_RIGHT, ALIGN_BOTTOM, "", -1, -1, "standard", Toolkit::getStringTable()->getString("[Start]"), 0, '\r'));

addWidget(new TextButton(20, 20, 70, 25, ALIGN_LEFT, ALIGN_BOTTOM, "", -1, -1, "standard", Toolkit::getStringTable()->getString("[Cancel]"), 1, 27));

Kieran <k776>
Project Administrator
Tue 07 Mar 2006 09:20:09 PM UTC, comment #4:

just ran glob2 on my winXP system and didn't have any problems. Reading through what you posted along with the source in campaignscreen.cpp I found that I have different code. I've simply been editing what I downloaded off the website when I first downloaded/compild the game (no current RPM's for fedora yet) and didn't go through CVS. There is no cancel button only a start button on this version so there isn't anything to conflict. I obviously need to get some updated code from CVS.

Kevin Clement <donkyhotay>
Project MemberIn charge of this item.
Tue 07 Mar 2006 09:01:46 PM UTC, comment #3:

Is it possible its a win32 only bug? I will test on Mandriva when I have the time.

Kieran <k776>
Project Administrator
Tue 07 Mar 2006 08:59:39 PM UTC, comment #2:

maybe I already have the fix but I wasn't able to recreate the problem.

Kevin Clement <donkyhotay>
Project MemberIn charge of this item.
Tue 07 Mar 2006 07:16:21 AM UTC, comment #1:

This is in CVS btw. I know how to fix it too. Open src/CampaignScreen.cpp, find:

addWidget(new TextButton(20, 20, 70, 25, ALIGN_RIGHT, ALIGN_BOTTOM, "", -1, -1, "standard", Toolkit::getStringTable()->getString("[Cancel]"), 1, 27));

And replace with:

addWidget(new TextButton(20, 55, 70, 25, ALIGN_LEFT, ALIGN_BOTTOM, "", -1, -1, "standard", Toolkit::getStringTable()->getString("[Cancel]"), 1, 27));

Id do it myself, but I dont have cvs access (or if I do, I dont know why I can't commit anything) :(

Kieran <k776>
Project Administrator
Tue 07 Mar 2006 07:07:01 AM UTC, original submission:

When you load the game, go to campaign screen, choose a mission, and hit play, on the mission screen the two buttons are wrongly placed. There is a line going right through the top one. Same thing when going to the tutorial.

Kieran <k776>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #1582:  oddbuttons.jpg added by k776 (57KiB - image/jpeg - can you see the odd buttons?)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 6 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 08 Mar 2006 03:28:58 AM UTCdonkyhotayStatusConfirmed=>Fixed
  Assigned toNone=>donkyhotay
  Open/ClosedOpen=>Closed
Tue 07 Mar 2006 09:53:41 PM UTCdonkyhotayStatusNone=>Confirmed
Tue 07 Mar 2006 07:07:01 AM UTCk776Attached File-=>Added oddbuttons.jpg, #3476
  Carbon-Copy-=>Added -unavailable-

Back to the top


Powered by Savane 3.1-cleanup1