bugGlobulation 2 - Bugs: bug #16348, Possible unoptimised code in...

 
 

bug #16348: Possible unoptimised code in Building::unitsXXX.size()

Submitted by:  Stephane Magnenat <nct>
Submitted on:  Sat 15 Apr 2006 04:43:30 PM UTC  
 
Severity: 2 - MinorStatus: Confirmed
Assigned to: Luc-Olivier de Charrière <nuage>Open/Closed: Closed
Release: NoneOperating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 13 Mar 2008 12:55:10 PM UTC, comment #1:

i'd like to close this as it should at max be a comment in the code what i just did.

Leo Wandersleb <giszmo>
Project Member
Sat 15 Apr 2006 04:43:30 PM UTC, original submission:

Buildings have several lists of units, such as unitsWorkings or unitsInside. Often, the length of those list are queried, by calling std::list::size(). Those call are potentially O(n) where n is the length of the list. Some profiling should be done to see if this affects performance, and, if so, improve it by keeping the size of the list in a separate variable.

Nuage and Steph

Stephane Magnenat <nct>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by giszmo (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 13 Mar 2008 12:55:10 PM UTCgiszmoOpen/ClosedOpen=>Closed
      Dependencies-=>Depends on bugs #16229

    Back to the top


    Powered by Savane 3.1-cleanup1