buglwIP - A Lightweight TCP/IP stack - Bugs: bug #1686, Ethernet drivers must be fixed.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #1686: Ethernet drivers must be fixed.

Submitted by:  Leon Woestenberg <likewise>
Submitted on:  Mon 11 Nov 2002 02:55:06 PM UTC  
 
Category: NoneSeverity: 6 - Security
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Leon Woestenberg <likewise>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Wed 07 May 2003 08:59:40 PM UTC, comment #3:

Closed. Bug report is now obsolete.

The correct way of implementing the ethif_output function is in the contrib modules 'c16x' and 'coldfire'.

Leon Woestenberg <likewise>
Project MemberIn charge of this item.
Thu 27 Feb 2003 10:26:38 AM UTC, comment #2:

set default send reg edit !!
//type maraset default send reg ..
mvh n

Anonymous
Wed 18 Dec 2002 10:25:02 AM UTC, comment #1:

With the new etharp.c in place (revision 1.13 checked in on 2002/11/29) this change is no longer needed, as the etharp.c layer now transmits all ARP traffic and queued packets on its behalf. The new skeleton becomes:

err_t ethif_output(struct netif netif, struct pbuf p, struct ip_addr *ipaddr)
{
p = etharp_output(netif, ipaddr, p);
/* network hardware address obtained? */
if (p != NULL)
{
/* send out the packet */
cs8900_output(netif, p);
p = NULL;
}
return ERR_OK;

Leon Woestenberg <likewise>
Project MemberIn charge of this item.
Mon 11 Nov 2002 02:55:06 PM UTC, original submission:

A memory leak was found in the etharp.c and Ethernet drivers architecture. Ethernet drivers' output code must follow this skeleton:

err_t ethif_output(struct netif netif, struct pbuf p, struct ip_addr *ipaddr)
{
p = etharp_output(netif, ipaddr, p);
/* network hardware address obtained? */
if (p != NULL)
{
/* send out the packet */
cs8900_output(netif, p);
/* clean any ARP left-overs */
etharp_output_sent(p);
p = NULL;
}
return ERR_OK;

Leon Woestenberg <likewise>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 18 Dec 2002 10:25:02 AM UTClikewiseAssigned toNone=>NA
  Open/ClosedOpen=>(Error - Not Found)
Wed 18 Dec 2002 10:25:01 AM UTClikewiseStatusNone=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1