bugDazuko - Bugs: bug #16879, Dazuko (2.2.1) compile failed on...

 
 

bug #16879: Dazuko (2.2.1) compile failed on FreeBSD

Submitted by:  None
Submitted on:  Mon 19 Jun 2006 12:35:56 AM UTC  
 
Status: NoneAssigned to: John Ogness <ogman>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 29 Jul 2006 09:43:54 AM UTC, comment #2:

Hi,

This was fixed in theh 2.2.2-pre1 (and later) versions.

John Ogness <ogman>
Project AdministratorIn charge of this item.
Tue 27 Jun 2006 09:28:50 AM UTC, comment #1:

Yes, that is the correct solution. Thank you for pointing this out. I have made the changes to CVS and it will be available in the next pre-release.

John Ogness <ogman>
Project AdministratorIn charge of this item.
Mon 19 Jun 2006 12:35:56 AM UTC, original submission:

The problem is present on dazuko_freebsd.c and dazuko_freebsd5.c files. The dazuko_is_our_daemon function is waiting for 3 parameters. I think that you forget a NULL parameter.

--- dazuko_freebsd.c Wed Jun 14 20:14:51 2006
+++ dazuko_freebsd.c Wed Jun 14 20:15:36 2006
@@ -1580,7 +1580,7 @@
freebsd_setupid(&xp_id, uio->uio_procp);

/* return dev_major if process is not registered */
- if (!dazuko_is_our_daemon(&xp_id, NULL))
+ if (!dazuko_is_our_daemon(&xp_id, NULL, NULL))
return read_dev_major(uio);

return 0;

--- dazuko_freebsd5.c Wed Jun 14 20:14:51 2006
+++ dazuko_freebsd5.c Wed Jun 14 20:15:36 2006
@@ -1580,7 +1580,7 @@
freebsd_setupid(&xp_id, uio->uio_procp);

/* return dev_major if process is not registered */
- if (!dazuko_is_our_daemon(&xp_id, NULL))
+ if (!dazuko_is_our_daemon(&xp_id, NULL, NULL))
return read_dev_major(uio);

return 0;

Apparently It solve the problem, but is it the correct solution?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 29 Jul 2006 09:43:54 AM UTCogmanOpen/ClosedOpen=>Closed
Tue 27 Jun 2006 09:28:50 AM UTCogmanAssigned toNone=>ogman

Back to the top


Powered by Savane 3.1-cleanup1