bugAVR Downloader/UploaDEr - Bugs: bug #17053, stk500v2 Length bytes mis-ordered

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #17053: stk500v2 Length bytes mis-ordered

Submitted by:  None
Submitted on:  Fri 07 Jul 2006 06:32:14 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: InvalidPrivacy: Public
Assigned to: Joerg Wunsch <joerg_wunsch>Originator Name: Paul Turner
Originator Email: -unavailable-Open/Closed: Closed
Release: NoneProgrammer hardware: 
Device type: 

Fri 18 Aug 2006 03:40:57 PM UTC, comment #1:

Current AVR068 correctly describes the protocol as being
MSB first, which matches the implementation -- so there's
no bug here at all.

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.
Fri 07 Jul 2006 06:32:14 AM UTC, original submission:

As per app-note AVR068, MESSAGE_SIZE is 2 bytes, LSB (Least Significant Byte) first.

In stk500v2.c the stk500v2_send() routine has -

buf[2] = len / 256;
buf[3] = len % 256;

And the stk500v2_recv() routine has -

case sSIZE1:
DEBUGRECV("hoping for size LSB\n");
msglen = c*256;
state = sSIZE2;
break;
case sSIZE2:
DEBUGRECV("hoping for size MSB...");
msglen += c;
DEBUG(" msg is %d bytes\n",msglen);
state = sTOKEN;
break;

Which, as far as I can see is wrong (but consistent).
I just can't figure out why it would work, unless AVR068 is wrong.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Fri 18 Aug 2006 03:40:57 PM UTCjoerg_wunschStatusNone=>Invalid
  Assigned toNone=>joerg_wunsch
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1