bugmldonkey, a multi-networks file-sharing client - Bugs: bug #1722, file gets downloaded more than...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #1722: file gets downloaded more than 100% - false chunks received

Submitted by:  Invalid User ID <Invalid User ID>
Submitted on:  Fri 15 Nov 2002 02:14:53 PM UTC  
 
Category: CoreSeverity: 3 - Normal
Item Group: NoneStatus: None
Assigned to: NoneOpen/Closed: Closed
Release: Release: 2.00
Operating System: LinuxBinaries Origin: CVS / Self compiled
CPU type: None

Tue 02 Dec 2003 06:25:55 PM UTC, comment #5:

This patch report is very old. If the bug still exists in current
versions please post a new bug report - spiralvoice

spiralvoice <spiralvoice>
Project Administrator
Tue 26 Aug 2003 08:53:46 AM UTC, comment #4:

Last time I looked at the officiel eMule sources, ICH implementation was actually much more simple than that. When corruption is found, chunk is invalidated (but data not cleared).
Download starts over, overwriting previous data as it arrives; But md4 hash is recomputed each time, so eventually the chunk may get validated before being fully redownloaded...

Anonymous
Fri 22 Nov 2002 12:30:20 AM UTC, comment #3:

I could not find a specification of the ICH (Intelligent Corruption Handling) protocol extension, but it looks rather simple.
With standard edonkey protocol, you fetch chunks (9.5Mb) md4 hashes before downloading, then each time you complete a chunk, you use its reference hash to validate the chunk. If it doesn't match, the whole chunk is invalidated.
With ICH, when corruption is detected, you ask for md4 hashes of zones (180Kb) inside the chunk to another peer, and individually validate or invalidate zones, then only refetch corrupted zones...

Anonymous
Sun 17 Nov 2002 03:17:36 PM UTC, comment #2:

I tried downloading this file (giving the whole ed2k URL wasn't very wise; next time, if you really need to, only give MD4 hash and size, it's enough)
Download went to 101.6% or so, and the file completed normally, without my intervention...

Anonymous
Sat 16 Nov 2002 08:11:52 PM UTC, comment #1:

IP packets are checksummed, so corruption during transfer should be detected; But they're other sources of corruption (disk, memory,... of a peer)
The problem is that a given chunk doesn't usually come from just one source, but from several sources, so mldonkey would have to keep a list of involved sources for each chunk...
Another solution would be to implement the eMule's ICH protocol extension (or a similar extension).

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follows 1 latest change.

Date Changed By Updated Field Previous Value => Replaced By
Tue 02 Dec 2003 06:25:55 PM UTCspiralvoiceOpen/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1