bugruQueue - Bugs: bug #17271, advanced search not joining values...

 
 

bug #17271: advanced search not joining values from comment table

Submitted by:  John Fulton <jfulton>
Submitted on:  Wed 02 Aug 2006 08:11:32 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: John Fulton <jfulton>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 02 Aug 2006 09:48:18 PM UTC, comment #2:

Fixed and applied to live system.

Uploaded new search.php and functions-search.php to CVS

John Fulton <jfulton>
Project AdministratorIn charge of this item.
Wed 02 Aug 2006 08:35:15 PM UTC, comment #1:

Cause of the problem:

Line 120 of search.php sets the select fields that will be part of the query. The only field there related to the last_comment is the date_created. Note that you can specify this output field and get the desired result. Adding "last_comment.body as "last_comment.body'," into that string allows you to see the body as described as lacking in the original bug report.

However, this is not a good fix. Whatever is used to populate the form should be used to populate the $select_fields string. Line 266 of functions-search.php builds an array of search fields, I'll change things so that it can be reused and these fields can't mismatch again.

John Fulton <jfulton>
Project AdministratorIn charge of this item.
Wed 02 Aug 2006 08:11:32 PM UTC, original submission:

When using the web interface's search.php, setting the output_type value to "text" AND setting the "Fields to output" to any comment.* produces search results with that comment field missing. I.e. you can't include any comment values in a text outputed search result.

John Fulton <jfulton>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 02 Aug 2006 09:48:18 PM UTCjfultonStatusIn Progress=>Fixed
  Open/ClosedOpen=>Closed
Wed 02 Aug 2006 08:35:15 PM UTCjfultonStatusNone=>In Progress
  Assigned toNone=>jfulton

Back to the top


Powered by Savane 3.1-cleanup1