bugGluster - Bugs: bug #17288, argp support for all tools

 
 

bug #17288: argp support for all tools

Submitted by:  Anand Avati <avati>
Submitted on:  Thu 03 Aug 2006 03:22:06 PM UTC  
 
Category: GlusterFSSeverity: 5 - Blocker
Priority: 7 - HighItem Group: Improper behaviour
Status: FixedPrivacy: Public
Assigned to: Basavanagowda Kanur <gowda>Originator Name: 
Open/Closed: ClosedRelease: 
Operating System: GNU/LinuxReproducibility: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Aug 2006 10:32:05 AM UTC, comment #3:

the fix is not complete. argc calculation to fuse_main has to be calculated. the previous sizeof() will not work for calculating argc now since argv is not a fixed array, but dynamic.

below is the line which will fail --

glusterfs-fops.c:glusterfs_mount() - return fuse_main ((sizeof (argv) / sizeof (char *)) - 1, argv, &glusterfs_fops);

Anand Avati <avati>
Project Member
Sun 06 Aug 2006 10:44:22 PM UTC, comment #2:

default options for glusterfs client must be given on command line only. Earlier hard-coding of mount options in glusterfs_mount have been removed.

also added new file glusterfs-ops.h to accomodate for a structure definition

Basavanagowda Kanur <gowda>
Project MemberIn charge of this item.
Thu 03 Aug 2006 09:06:12 PM UTC, comment #1:

glusterfs-fuse should propogate appropriate -o args to fuse_main()

Anand Avati <avati>
Project Member
Thu 03 Aug 2006 03:22:06 PM UTC, original submission:

argp should be used in -

1. glusterfs-fuse
2. glusterfsd
3. glusterfs-shell

Anand Avati <avati>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 8 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 07 Aug 2006 12:14:52 PM UTCgowdaStatusIn Progress=>Fixed
  Open/ClosedOpen=>Closed
Mon 07 Aug 2006 10:32:05 AM UTCavatiStatusFixed=>In Progress
Sun 06 Aug 2006 10:44:22 PM UTCgowdaStatusIn Progress=>Fixed
Fri 04 Aug 2006 11:29:51 PM UTCgowdaStatusNone=>In Progress
Thu 03 Aug 2006 09:06:12 PM UTCavatiSeverity1 - Wish=>5 - Blocker
  Priority5 - Normal=>7 - High
Thu 03 Aug 2006 08:51:13 PM UTCavatiAssigned toNone=>gowda

Back to the top


Powered by Savane 3.1-cleanup1