Wed 13 Sep 2006 09:49:42 AM UTC, comment #9:
Added another CSS fix for driverInteractive.ml
(looks like code duplication, though)
|
Wed 13 Sep 2006 09:48:40 AM UTC, comment #8:
Added a CSS fix for driverCommands.ml
|
Wed 13 Sep 2006 09:41:26 AM UTC, comment #7:
Output of "vs" is not affected because it uses a different style sheet (dh.css).
Attached a version with readable CSS and underlined links.
How do you want it to look like?
|
Tue 12 Sep 2006 10:36:28 PM UTC, comment #6:
"Hmm.. does that surprise you?"
Yes, because I do not know anything about CSS;-)
Sorry, but for fixing this patch I can only code what you, and
others, are proposing. Or better, send in a complete patch;-)
Attached a new version with your proposals, links look blue now, thanks, but they are not underlined like in current MLDonkey.
Output of "vs" however is not touched by that, it looks black
and also not underlined.
|
Tue 12 Sep 2006 08:29:19 PM UTC, comment #5:
Hmm.. does that surprise you?
After all, you colored them black (@color_anchor@ expands to #000 on my system).
If you leave the semicolon in place, the selector
"; a:link,a:active,a:visited"
does not match anything (since it's invalid) and so the links get the default color (sometimes blue). If you want valid css and blue links, you should add something like
td.sr a { color: #0000ff; }
|
Tue 12 Sep 2006 07:40:46 PM UTC, comment #4:
"The 1st patch corrects the semicolon"
This patch is wrong, I must leave the code as-is otherwise
no links (for example in vd #num) are shown in blue color.
See updated patch h_css2.patch with your comments added.
|
Mon 11 Sep 2006 08:27:08 AM UTC, comment #3:
The 1st patch corrects the semicolon, but below the corrected line is yet another "font-face" that should be "font-family".
I also looked at h_css.patch and think that you could remove the "border-width" properties in the last hunk, because the width is already specified (border: @color_general_border@ solid 1px).
|
Sun 10 Sep 2006 09:46:58 PM UTC, comment #2:
For the rest, is the attached patch ok?
|
Sun 10 Sep 2006 09:43:34 PM UTC, comment #1:
"Line 20: Semicolon outside of declaration; should be after color code."
Is this patch correct?
--- ././src/daemon/common/commonMessages.ml 2006-08-26 14:05:53.000000000 +0200
+++ ././src/daemon/common/commonMessages.ml 2006-09-10 23:41:15.000000000 +0200
@@ -65,7 +61,7 @@
input.but2 { background: @color_bsmall3@;
border: 0px; padding: 0px; font: bold 10px verdana;
width: 36px; height: 14px; }
-input.but { background: @color_input_button@ };
+input.but { background: @color_input_button@; }
a:link,a:active,a:visited { text-decoration: none; font-face: verdana;
font-size: 10px; color: @color_anchor@; }
If I use MLDonkey with this patch EDK links in upstats can
not be clicked anymore, if I remove the patch everything is ok.
Tested with Firefox 1.5.0.6/Linux and Konqueror 3.5.4.
|
Sat 09 Sep 2006 11:40:07 AM UTC, original submission:
The style sheet used by the HTML GUI (h.css) has some errors:
Line 20: Semicolon outside of declaration; should be after color code.
Line 64: "font-face" should be "font-family"
Line 80: "border: 1;" should be "border-width: 1px;"
Line 83: same (border specified twice)
Line 84: same
Line 5-8: Coloring the scrollbars is non-standard.
|