bugThe FreeType Project - Bugs: bug #17843, PFR kerning bug and fix

 
 

bug #17843: PFR kerning bug and fix

Submitted by:  None
Submitted on:  Mon 25 Sep 2006 01:14:30 PM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.0

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 27 Sep 2006 06:29:08 AM UTC, comment #1:

Applied, thanks.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Mon 25 Sep 2006 01:14:30 PM UTC, original submission:

Hello, I’ve just found and fixed a bug in pfrobjs.c with pfr_face_get_kerning()

Another font library returned 1030 kerning pairs but FT 2.2.1 only returned 379 pairs on the same font for a specific set of glyphs.

I found the bug was because the adjustment byte(s) were not skipped preventing a proper search of the kerning data.

The diffs are as follows:

Index: pfrobjs.c
===================================================================
RCS file: /cvsroot/freetype/freetype2/src/pfr/pfrobjs.c,v
retrieving revision 1.35
diff -r1.35 pfrobjs.c
485a486

> FT_Bool twobyte_adjustment = FT_BOOL( item->flags & 2 );

502a504,508

> {
> if ( twobyte_adjustment )
> p += 2;
> else
> p++;

503a510

> }

536c543
< if ( item->flags & 2 )
---

> if ( twobyte_adjustment )


Regards,
David Bustin
Software Engineer
Cabot Communications Ltd.
Verona House, Filwood Road,
Bristol BS16 3RY
UK
Email: david DOT bustin AT cabot DOT co DOT uk
http://www.cabot.co.uk
Interactive Digital TV Technology Solutions

  • Complete the Digital Picture *
Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #10843:  pfrobjs.c added by None (17KiB - text/plain - Modified pfrobjs.c to fix bug in pfr_face_get_kerning())

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 5 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 27 Sep 2006 06:29:08 AM UTCwlStatusNone=>Fixed
  Assigned toNone=>wl
  Open/ClosedOpen=>Closed
  Planned ReleaseNone=>2.3.0
Mon 25 Sep 2006 01:14:31 PM UTCNoneAttached File-=>Added pfrobjs.c, #10843

Back to the top


Powered by Savane 3.1-cleanup1