buglwIP - A Lightweight TCP/IP stack - Bugs: bug #18065, ID in IP-Header is ZERO for all...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #18065: ID in IP-Header is ZERO for all outgoing IP-packets

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Fri 20 Oct 2006 09:15:55 AM UTC  
 
Category: IPv4Severity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Wed 01 Nov 2006 09:34:52 AM UTC, comment #4:

Made ip_id static again. This is required when outputting IP fragments.

Christiaan Simons <christiaans>
Project Member
Mon 23 Oct 2006 07:56:23 AM UTC, comment #3:

IP ID is essentially optional, so while this might be unintended behaviour, it's not breaking the spec.

Kieran Mansley <kieranm>
Project Administrator
Mon 23 Oct 2006 07:55:44 AM UTC, comment #2:

IP ID is essentially optional, so while this might be unintended behaviour, it's not breaking the spec.

Anonymous
Fri 20 Oct 2006 11:42:15 AM UTC, comment #1:

Hmm, likewise seems to have introduced this in ip.c 1.32. (lwIP 1_0_0) I guess for the purpose to have separate IDs for each netif, but I'm unsure what rfc791 says about this.

The current behavior is clearly wrong, i'll have a look at it.

Christiaan Simons <christiaans>
Project Member
Fri 20 Oct 2006 09:15:55 AM UTC, original submission:

The reason is that int ip_output_if(), the variable ip_id (used to assign the IDs to the packets) is not declared static. It is declare in line 386, used for assignment in line 409 and incremented (for the next packet) in line 410.

But since it is not static, the next time ip_output_if() is called, it is set back to 0 again, resulting in all outgoing IP-packets with ID=0.

Simon Goldschmidt <goldsimon>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 01 Nov 2006 09:34:52 AM UTCchristiaansStatusNone=>Fixed
  Open/ClosedOpen=>Closed

Back to the top


Powered by Savane 3.1-cleanup1