bugFle3 is a Learning Environment - Bugs: bug #184, Notes can't handle quotes

 
 

bug #184: Notes can't handle quotes

Submitted by:  Tarmo Toikkanen <tarmo>
Submitted on:  Tue 07 May 2002 10:48:11 AM UTC  
 
Category: Knowledge BuildingSeverity: Normal
Item Group: Bad functionalityStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: None
Client software: Server software: 

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 07 May 2002 10:54:44 AM UTC, comment #7:

[from previous tracker]
[submitted at 18/01 2002 15:38 by Anonymous]

Fixed by Bo's patch #1.

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:54:42 AM UTC, comment #6:

[from previous tracker]
[submitted at 16/01 2002 17:15 by Anonymous]

Bo's working on this part, so it'll be up to him to fix or ignore this.

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:54:41 AM UTC, comment #5:

[from previous tracker]
[submitted at 10/01 2002 12:40 by Anonymous]

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:54:37 AM UTC, comment #4:

[from previous tracker]
[submitted at 10/01 2002 06:22 by Anonymous]

If I remember correctly, there was some reasoning to use the hidden field there. Can't remember what it was, so we might as well fix this bug. Do you want to do it, tarmo?

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:54:35 AM UTC, comment #3:

[from previous tracker]
[submitted at 04/01 2002 15:17 by Anonymous]

Well, in addition to quotes, angle brackets used in HTML are also dangerous (although many browsers might just handle them). So we probably should run the message body through a URLEncode when building the form with the data in hidden fields.
Btw, do we really need the hidden field for the body? The data is in the textarea anyway.

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:54:34 AM UTC, comment #2:

[from previous tracker]
[submitted at 30/11 2001 14:09 by Anonymous]

Should we perhaps encode with these &#2323; things the whole message in the hidden fields? This way we would only have generic stuff to handle, and no need to special-case stuff.
It might be that this is not the problem in the first hand. Can you please add a followup?

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:54:31 AM UTC, comment #1:

[from previous tracker]
[submitted at 22/11 2001 12:57 by Anonymous]

Yep, the problem is in the hidden form field that contains the message body - quotes should probably be escaped.

Tarmo Toikkanen <tarmo>
Project Administrator
Tue 07 May 2002 10:48:11 AM UTC, original submission:

[from previous tracker]
[submitted at 20/11 2001 19:03]

Apparently note preview and publishing breaks if the note contains double quotes (").

Tarmo Toikkanen <tarmo>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 07 May 2002 10:54:51 AM UTCtarmoStatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)
  Fixed ReleaseNone=>(Error - Not Found)
  Closed on-=>-

Back to the top


Powered by Savane 3.1-cleanup1