bugmldonkey, a multi-networks file-sharing client - Bugs: bug #18833, Reassigned to another tracker...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #18833: Reassigned to another tracker [was: http_client: Retry GET request if HEAD request returns http error 400]

Submitted by:  Markus Tacker <tacker>
Submitted on:  Fri 19 Jan 2007 01:37:47 PM UTC  
 
Category: HTTP interfaceSeverity: 3 - Normal
Item Group: Program malfunctionStatus: Ready For Test
Assigned to: NoneOpen/Closed: Closed
Release: 2.8.2Release: 2.8.2
Operating System: LinuxBinaries Origin: Gentoo ebuild
CPU type: None

Sun 04 Feb 2007 05:26:35 PM UTC, comment #5:

THIS ITEM WAS REASSIGNED TO PATCH #5724.

Please, do not post any new comments to this item.


spiralvoice <spiralvoice>
Project Administrator
Fri 26 Jan 2007 02:18:56 PM UTC, comment #4:

dllink http://....

loads HTTP headers with a HEAD request for further inspection.
The tracker mentioned here answers all HEAD requests with error
400 which stops the download process of the torrent file.
I tested this by sending the a GET and a HEAD request with Telnet.

Without a correct header answer MLDonkey does not know what
to do with the URL because dllink is a generic command for all
network modules. All networks are called with the received headers,
BT module has this code to analyze HTTP headers and find the
ones its responsible for:

if (valid_torrent_extension real_url)
|| (String2.contains url "Content-Type: application/x-bittorrent")

But the error 400 stops the dllink process because it returns
no data worth analyzing.
I attached a patch which repeats a HEAD request as GET in the
lower network module http_client if a HEAD request returned
error 400, please test.

This will lead to the situation that dllink does a GET request
with this URL, BT module parses the headers, finds out that its
responsible for the URL and does a GET request again to get the
torrent file. Because of the generic structures of the common
and net modules in MLDonkey downloading the .torrent file twice
here can not be avoided. Using command "startbt" avoids
downloading the torrent file twice because its especially made
for BT and does a GET request right at away.

(file #11868)

spiralvoice <spiralvoice>
Project Administrator
Fri 26 Jan 2007 01:05:30 PM UTC, comment #3:

> The URL mentioned in this bug works with the command "startbt" which was created especially for BT downloads.

Confirmed. But it should also work with dllink, should'nt it?

Markus Tacker <tacker>
Fri 26 Jan 2007 12:56:01 PM UTC, comment #2:

The URL mentioned in this bug works with the command "startbt" which was created especially for BT downloads.

spiralvoice <spiralvoice>
Project Administrator
Fri 19 Jan 2007 07:08:08 PM UTC, comment #1:

Closed, duplicate of bug #18750

spiralvoice <spiralvoice>
Project Administrator
Fri 19 Jan 2007 01:37:47 PM UTC, original submission:

THIS ITEM WAS REASSIGNED TO PATCH #5724.

Adding this URL als dllink does not work:
http://tracker.etn.fm:7979/torrent.html?info_hash=85d12bcc4839d1a1bcfc526dffce16f76c27efe5

Markus Tacker <tacker>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spiralvoice (Posted a comment)
  • -unavailable- added by tacker (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 04 Feb 2007 05:26:35 PM UTCspiralvoiceReassign Itemmldonkey, a multi-networks file-sharing client, bug #18833=>mldonkey, a multi-networks file-sharing client, patch #5724
    Sun 04 Feb 2007 05:26:34 PM UTCspiralvoiceSummaryETN.fm torrent url not added=>http_client: Retry GET request if HEAD request returns http error 400
    Fri 26 Jan 2007 02:18:56 PM UTCspiralvoiceAttached File-=>Added http_400head.patch, #11868
      StatusDuplicate=>Ready For Test
      Open/ClosedClosed=>Open
    Fri 19 Jan 2007 07:08:08 PM UTCspiralvoiceStatusNone=>Duplicate
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1