bugmonotone - Bugs: bug #18887, sync_type unset in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #18887: sync_type unset in note_netsync_start?

Submitted by:  Thomas Keller <tommyd>
Submitted on:  Fri 26 Jan 2007 12:23:32 PM UTC  
 
Category: networkingSeverity: 3 - Normal
Item Group: incorrect behaviorStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

mtn 0.31

Thu 26 Feb 2009 01:14:23 PM UTC, comment #3:

It looks like sync_type and my_role are always set now, so this must have been fixed.

print("status: " + status) is trying to do arithmetic on the string "status: ", the variable status really is an integer.

Timothy Brownawell <tbrownaw>
Project Member
 Spam posted by an anonymous
Fri 26 Jan 2007 12:41:04 PM UTC, comment #2:

And, status from note_netsync_end is also not set. There is seriously something going wrong. status should be an integer, but lua tells me

mtn: warning: ...askeller.biz/subdomains/guitone/.monotone/monotonerc:46: attempt to perform arithmetic on a string value

if I do something like

print("status: " + status)

in note_netsync_end

Thomas Keller <tommyd>
Project Administrator
Fri 26 Jan 2007 12:26:22 PM UTC, comment #1:

The same is true for the second parameter, my_role. It seems as only session_id is set.

Thomas Keller <tommyd>
Project Administrator
Fri 26 Jan 2007 12:23:32 PM UTC, original submission:

This is the first part of my monotonerc file:

_branch = "biz.thomaskeller.guitone.website"
_updater = "/var/www/vhosts/thomaskeller.biz/subdomains/guitone/update_web.sh"
_sessions = {}

function note_netsync_start (session_id, my_role, sync_type,remote_host, remote_keyname, includes, excludes)
print("start: " .. session_id .. " " .. my_role .. " " .. sync_type)
if my_role == "server" and sync_type ~= "pull" then
print("netsync_start: data are pushed or synced")
_sessions[session_id] = 0
end
end
[...]

If I serve a db with this file and I push a revision to the server, the server console logs the following:

mtn: warning: ...askeller.biz/subdomains/guitone/.monotone/monotonerc:6: attempt to concatenate local 'sync_type' (a nil value)

Shouldn't sync_type be set to one of "push", "pull" or "sync", as the docs state?

Thomas Keller <tommyd>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tbrownaw (Posted a comment)
  • -unavailable- added by tommyd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 26 Feb 2009 01:14:23 PM UTCtbrownawStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1