buglwIP - A Lightweight TCP/IP stack - Bugs: bug #1890, Ethernet drivers shouldn't use...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #1890: Ethernet drivers shouldn't use PBUF_LINK in pbuf_alloc on receive

Submitted by:  None
Submitted on:  Thu 05 Dec 2002 07:54:34 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Leon Woestenberg <likewise>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Wed 08 Jan 2003 09:12:41 AM UTC, comment #2:

Fixed for cs8900 and ethernetif.c skeleton (which is still out of sync in other area's).

Leon Woestenberg <likewise>
Project MemberIn charge of this item.
Wed 18 Dec 2002 10:27:36 AM UTC, comment #1:

Yes this should be done.Moreover PBUF_LINK should depend on
the netif and not be a fixed define since there can be two
interfaces on one system (i.e. slip and ether) with diffrenet link header sizes.For slip it's 0.

Jani Monoses <jani>
Project Member
Thu 05 Dec 2002 07:54:34 AM UTC, original submission:

As discussed on the mailing list recently <URL: http://www.sics.se/mailing-lists/lwip.html/msg01860.html>, Ethernet drivers should allocate a PBUF_RAW for a received buffer now that Jani has changed the behaviour of PBUF_LINK in pbuf.c. If PBUF_LINK is used, additional PBUF_LINK_HLEN bytes gets allocated for every input packet, which already contains the Ethernet header.

This applies to at least Leon's cs8900 driver and the ethernetif.c skeleton (which is out of sync anyway). Don't know about non-Ethernet link layers, such as slipif.c etc.

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Wed 08 Jan 2003 09:12:41 AM UTClikewiseAssigned toNone=>NA
  Open/ClosedOpen=>(Error - Not Found)
Wed 08 Jan 2003 09:12:40 AM UTClikewiseStatusNone=>(Error - Not Found)

Back to the top


Powered by Savane 3.1-cleanup1