bugAVR C Runtime Library - Bugs: bug #18964, USART definitions *wrong* in...

 
 

bug #18964: USART definitions *wrong* in iocanxx.h

Submitted by:  None
Submitted on:  Mon 05 Feb 2007 05:33:28 PM UTC  
 
Category: HeaderSeverity: 3 - Normal
Priority: 7 - HighItem Group: libc code
Status: FixedPercent Complete: 0%
Assigned to: Joerg Wunsch <joerg_wunsch>Originator Email: -unavailable-
Open/Closed: ClosedRelease: None
Fixed Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 23 Oct 2007 12:28:38 PM UTC, comment #3:

While the SIG_xxx names are deprecated, it seems counterintuitive
that the SIG_UART* names were there but the SIG_USART* names
weren't, so I applied the patch.

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.
Fri 30 Mar 2007 05:18:26 PM UTC, comment #2:

From the avr-libc user manual:

"Starting with avr-libc version 1.4.0, a second style of interrupt vector names has been added, where a short phrase for the vector description is followed by _vect. The short phrase matches the vector name as described in the datasheet of the respective device (and in Atmel's XML files), with spaces replaced by an underscore and other non-alphanumeric characters dropped. Using the suffix _vect is intented to improve portability to other C compilers available for the AVR that use a similar naming convention.

The historical naming style might become deprecated in a future release, so it is not recommended for new projects."

Note the last sentence. The iocanxx.h has the correct naming with the "USART" prefix. The vector names that start with "SIG" should not be used anymore.

Eric Weddington <arcanum>
Project Administrator
Sun 25 Mar 2007 03:11:37 AM UTC, comment #1:

Attached patch fixes this.

-Colin

(file #12282)

Colin O Flynn <c_oflynn>
Mon 05 Feb 2007 05:33:28 PM UTC, original submission:

Hello

the iocanxx.h lacks some vector definitions.
I saw it because the Aversive lib uses the presence of the USART vectors to detect if it is an UART or USART.

iocanxx.h :
/* USART0, Rx Complete */
#define USART0_RX_vect _VECTOR(21)
#define SIG_UART0_RECV _VECTOR(21)

iom128.h :
/* USART0, Rx Complete */
#define USART0_RX_vect _VECTOR(18)
#define SIG_USART0_RECV _VECTOR(18)
#define SIG_UART0_RECV _VECTOR(18)

it cis in my opinion logical to add the usart defined vectors.

Tschüss

christoph

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #12282:  bug18964.diff added by c_oflynn (3KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by joerg_wunsch (Posted a comment)
  • -unavailable- added by c_oflynn (Updated the item)
  • -unavailable- added by arcanum (Updated the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 23 Oct 2007 12:28:38 PM UTCjoerg_wunschStatusNeed Info=>Fixed
      Open/ClosedOpen=>Closed
    Sun 06 May 2007 03:54:22 PM UTCarcanumPriority9 - Immediate=>7 - High
      StatusInvalid=>Need Info
    Fri 30 Mar 2007 07:38:36 PM UTCarcanumAssigned toarcanum=>joerg_wunsch
      Open/ClosedClosed=>Open
    Fri 30 Mar 2007 05:18:26 PM UTCarcanumStatusNone=>Invalid
      Assigned toNone=>arcanum
      Open/ClosedOpen=>Closed
    Sun 25 Mar 2007 03:11:37 AM UTCc_oflynnAttached File-=>Added bug18964.diff, #12282
    Sun 25 Mar 2007 01:01:34 AM UTCarcanumPriority5 - Normal=>9 - Immediate

    Back to the top


    Powered by Savane 3.1-cleanup1