buglwIP - A Lightweight TCP/IP stack - Bugs: bug #19251, missing `const' qualifier in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #19251: missing `const' qualifier in socket functions

Submitted by:  Dmitry Potapov <dpotapov>
Submitted on:  Thu 08 Mar 2007 11:38:16 PM UTC  
 
Category: sockets/netconnSeverity: 3 - Normal
Item Group: Change RequestStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Wed 21 Mar 2007 09:20:36 PM UTC, comment #4:

Fixed by applying the patch.

-> closed. (Although I think there might be some more compatiblity work to be done)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 09 Mar 2007 12:33:40 PM UTC, comment #3:

Hey, that's exactly what I was looking for. Maybe we should try to be compatible to that regarding types and include paths...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Fri 09 Mar 2007 12:12:04 PM UTC, comment #2:

Simon,
I think the following link may be useful for you:
http://www.opengroup.org/onlinepubs/009695399/toc.htm

Dmitry Potapov <dpotapov>
Fri 09 Mar 2007 07:33:48 AM UTC, comment #1:

Talking about 'the standard', do you know where to get a description of the 'standard' socket layer? I mean, it would be good looking at that when creating new functionality like the current SO_RCVTIMEO development. I only can look at linux man pages or windows documentation, and both have some extra-stuff included which in my opinion does not belong into lwip...

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 08 Mar 2007 11:38:16 PM UTC, original submission:

Prototypes of a few socket functions do not have `const', though it is required by the standard, and that causes warnings in user programs.

I have found four functions in socket.h, in which prototypes `const' is missing:
lwip_connect(), lwip_send(), lwip_sendto(), lwip_write().

Also, `const' is missing in the following netconn functions:
netbuf_ref() and netconn_write()

I have attached a patch to correct the problem.

Dmitry Potapov <dpotapov>

 

Attached Files
file #12156:  add-const.patch added by dpotapov (5KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by dpotapov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 21 Mar 2007 09:20:36 PM UTCgoldsimonStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 09 Mar 2007 08:04:34 AM UTCgoldsimonStatusNone=>Confirmed
      Assigned toNone=>goldsimon
    Thu 08 Mar 2007 11:38:16 PM UTCdpotapovAttached File-=>Added add-const.patch, #12156

    Back to the top


    Powered by Savane 3.1-cleanup1