bugWeeChat - Bugs: bug #19846, Invalid ping handling

 
 

bug #19846: Invalid ping handling

Submitted by:  None
Submitted on:  Thu 10 May 2007 06:26:05 AM UTC  
 
Category: irc pluginSeverity: 3 - Normal
Item Group: irc protocolStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: darkkOriginator Email: -unavailable-
Open/Closed: ClosedRelease: None
IRC nick: 

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 10 May 2007 06:26:05 AM UTC, original submission:

from server: PING :foobar
weechat reply: PONG ::foobar
expected: PONG :foobar

I'm not sure, that I'm right about expected reply and the way to fix it, but simple patch helps me:

@@ -1200,6 +1200,8 @@ irc_cmd_recv_ping (t_irc_server *server,
pos = strrchr (arguments, ' ');
if (pos)
pos[0] = '\0';
+ if (arguments[0] == ':') // not sure if it's good idea
+ arguments++;
server_sendf (server, "PONG :%s", arguments);
return 0;
}

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 10 May 2007 09:23:47 AM UTCflashcodeCategoryNone=>irc plugin
      Item GroupNone=>irc protocol
      StatusNone=>Fixed
      Assigned toNone=>flashcode
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1