bugrdiff-backup - Bugs: bug #19896, fs_abilities.py set_symlink_perms...

 
 

bug #19896: fs_abilities.py set_symlink_perms raises OSError when creating symlink on cifs volume

Submitted by:  Jonathan Hankins <jonathanhankins>
Submitted on:  Fri 18 May 2007 03:15:29 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 May 2007 06:46:13 PM UTC, comment #2:

applied to cvs, thanks

dean gaudet <dgaudet>
Project Administrator
Sat 19 May 2007 01:39:13 AM UTC, comment #1:

Oops, I got bitten by python's whitespace requirements in my patch. I have attached the fixed patch, and gave it a better name. See also #19895 -- I have a patch for that bug report, and it will apply cleanly before or after (with a little fuzz) this one.

(file #12799)

Jonathan Hankins <jonathanhankins>
Fri 18 May 2007 03:15:29 AM UTC, original submission:

symlink() doesn't work on a cifs-mounted Windows share, and there is an unprotected call to symlink() in set_symlink_perms. Attached is a patch that catches the exception and sets symlink_perms to zero. I tested it a bit, but please double-check me :-)

Jonathan Hankins <jonathanhankins>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #12799:  fs_abilities.py.set_symlink_perms.diff added by jonathanhankins (906B - application/octet-stream - Same patch with correct whitespace (I hope) and better name)
file #12793:  fs_abilities.py.diff added by jonathanhankins (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dgaudet (Posted a comment)
  • -unavailable- added by jonathanhankins (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 May 2007 06:46:13 PM UTCdgaudetOpen/ClosedOpen=>Closed
    Sat 19 May 2007 06:46:12 PM UTCdgaudetStatusNone=>Fixed
    Sat 19 May 2007 01:39:13 AM UTCjonathanhankinsAttached File-=>Added fs_abilities.py.set_symlink_perms.diff, #12799
    Fri 18 May 2007 03:15:29 AM UTCjonathanhankinsAttached File-=>Added fs_abilities.py.diff, #12793

    Back to the top


    Powered by Savane 3.1-cleanup1