bugThe eXtended osip library - Bugs: bug #20130, To header field no tag in fresh...

 
 

bug #20130: To header field no tag in fresh subscirbe message

Submitted by:  Yingtao Duan <c_nwwolf>
Submitted on:  Sat 09 Jun 2007 05:20:43 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Aymeric MOIZARD <aymeric>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 08 Jun 2011 02:32:19 PM UTC, comment #5:

I'm closing this old issue. Most probably fixed...

Aymeric MOIZARD <aymeric>
Project AdministratorIn charge of this item.
Mon 11 Jun 2007 11:32:14 AM UTC, comment #4:

You are right.

this is old patch that i'm using.

/add by d56402 on 2007-05-12[begin]/
{
osip_generic_param_t *tag = NULL;

osip_to_get_tag(msg->to, &tag);
if (NULL == tag && jd != NULL && jd->d_dialog != NULL)
{
osip_to_set_tag(msg->to, osip_strdup(jd->d_dialog->remote_tag));
}
}
/add by d56402 on 2007-05-12[end]/

Yingtao Duan <c_nwwolf>
Sun 10 Jun 2007 05:07:58 PM UTC, comment #3:

Alright.
Your patch is wrong because it reuse a To tag which is wrong. (given by proxy after authentication).

I'll do more testing but the problem probably comes from the new functionnality implemented in "eXosip_release_finished_transactions_for_subscription" which regularaly release SUBSCRIBEs requests.

Aymeric MOIZARD <aymeric>
Project AdministratorIn charge of this item.
Sun 10 Jun 2007 11:36:51 AM UTC, comment #2:

version: libeXosip2-3.0.2
log: none
code: int
_eXosip_subscribe_send_request_with_credential (eXosip_subscribe_t * js,
eXosip_dialog_t * jd,
osip_transaction_t * out_tr)
{
osip_transaction_t *tr = NULL;
osip_message_t *msg = NULL;
osip_event_t *sipevent;

//......
i = eXosip_update_top_via(msg);
if (i!=0)
{
osip_message_free (msg);
OSIP_TRACE (osip_trace
(_FILE_, _LINE_, OSIP_ERROR, NULL,
"eXosip: unsupported protocol\n"));
return -1;
}

/Add by c_nwwolf on 2007-06-10[begin]/
if (msg->to != NULL)
{
osip_generic_param_t *param = NULL;

if (osip_to_get_tag(msg->to, &param) != 0)
{
if (out_tr->last_response == NULL || out_tr->last_response->to == NULL
|| osip_to_get_tag(out_tr->last_response->to, &param) != 0)
{
osip_message_free (msg);
return -1;
}
/add tag for the to header field/
osip_to_set_tag(msg->to, param->gvalue);
}
}
/Add by c_nwwolf on 2007-06-10[end]/

//......
}

(file #13001)

Yingtao Duan <c_nwwolf>
Sat 09 Jun 2007 09:25:18 AM UTC, comment #1:

Could you please provide more info:
version
log
some code to reproduce

Aymeric MOIZARD <aymeric>
Project AdministratorIn charge of this item.
Sat 09 Jun 2007 05:20:43 AM UTC, original submission:

I found that the to header field don't exsit tag in fresh subscirbe message.

Yingtao Duan <c_nwwolf>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #13001:  eXsubscription_api.c added by c_nwwolf (11KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by aymeric (Posted a comment)
  • -unavailable- added by c_nwwolf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 08 Jun 2011 02:32:19 PM UTCaymericStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sun 10 Jun 2007 05:08:20 PM UTCaymericStatusNeed Info=>In Progress
    Sun 10 Jun 2007 11:36:51 AM UTCc_nwwolfAttached File-=>Added eXsubscription_api.c, #13001
    Sat 09 Jun 2007 09:25:18 AM UTCaymericAssigned toNone=>aymeric
    Sat 09 Jun 2007 09:25:17 AM UTCaymericStatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup1