bugBibORB - Bugs: bug #20219, Localization of $GET['mode'] value

 
 

bug #20219: Localization of $GET['mode'] value

Submitted by:  None
Submitted on:  Wed 20 Jun 2007 10:54:39 AM UTC  
 
Category: InternationalizationSeverity: 3 - Normal
Item Group: ErrorsStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 1.3.3Fixed Release: None
Planned Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 20 Jun 2007 11:01:13 AM UTC, comment #1:

Read msg('Select') instead of msgstr('Select')...

Anonymous
Wed 20 Jun 2007 10:54:39 AM UTC, original submission:

In bibindex.php, there is a msgstr('Select') case within the switch($mode). This results in not matching the case if that message string contains html special characters. A hot fix is to strip html special characters. A much better solution is to not localize $GET values at all:

In bibindex.php, change

case msgstr('Select'):

to

case 'Select':

and in php/interface-bibindex.php, function bibindex_entry_to_add() instead of

$content .= "&nbsp;<input class='submit' type='submit' name='mode' id='mode' value='".msg("Select")."'/>";

insert a hidden input which sets the mode value:

$content .= "<input name='mode' id='mode' value='Select' type='hidden'>";
$content .= "&nbsp;<input class='submit' type='submit' value='".msg("Select")."'/>";

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

No Changes Have Been Made to This Item

Back to the top


Powered by Savane 3.1-cleanup1