buglwIP - A Lightweight TCP/IP stack - Bugs: bug #20590, Byte ordering discrepency in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #20590: Byte ordering discrepency in ipv4/ip_addr.h

Submitted by:  Jared Grubb <jgrubb>
Submitted on:  Thu 26 Jul 2007 03:45:29 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Invalid
Privacy: PublicAssigned to: Jonathan Larmour <jifl>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Thu 26 Jul 2007 07:16:20 PM UTC, comment #2:

Yes the values are expected to be in host byte order already.

On your host system you may be able to see this in /usr/include/netinet/in.h there too.

Closing...

Jonathan Larmour <jifl>
Project MemberIn charge of this item.
Thu 26 Jul 2007 03:46:06 AM UTC, comment #1:

er.. ntohl().. its too late :)

Jared Grubb <jgrubb>
Project Member
Thu 26 Jul 2007 03:45:29 AM UTC, original submission:

I am working on the documentation, and was looking at some of the #define's in ip_addr.h. I am thinking there is an error in a few of them. Do the following need to have nhtol() around them?

  • #define INADDR_LOOPBACK ((u32_t)0x7f000001UL) /* 127.0.0.1 */
  • #define IN_CLASSA(a) ((((u32_t)(a)) & 0x80000000UL) == 0)

and a few others in the same idea. Am I right, or is there some assumption that the comparison is done on a value already in the right order?

Jared Grubb <jgrubb>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jifl (Posted a comment)
  • -unavailable- added by jgrubb (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 26 Jul 2007 07:16:20 PM UTCjiflStatusNone=>Invalid
      Assigned toNone=>jifl
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1