bugWeeChat - Bugs: bug #20646, weechat 0.2.5: terminal encoding...

 
 

bug #20646: weechat 0.2.5: terminal encoding detection fails if compiled without NLS support

Submitted by:  None
Submitted on:  Tue 31 Jul 2007 11:03:04 PM UTC  
 
Category: displaySeverity: 3 - Normal
Item Group: displayStatus: Fixed
Privacy: PublicAssigned to: Sebastien Helleu <flashcode>
Originator Name: ravenExOriginator Email: -unavailable-
Open/Closed: ClosedRelease: None
IRC nick: ravenEx

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 31 Jul 2007 11:03:04 PM UTC, original submission:

When compiled with --disable-nls switch, terminal encoding is always set to ASCII.
I believe it is reasonable to allow user to compile without native language messages and to use unicode locales at the same time.
Reason: weechat.c : main() : setlocale(LC_ALL,"") is placed within #ifdef ENABLE_NLS, so the program defaults to "C" locale when NLS is disabled.
With "C" locale the following call to nl_langinfo(CODESET) picks up ASCII encoding, no matter what $LANG is.
Suggested fix: to move setlocale() out of #ifdef, and the same thing in weechat.h for #include <locale.h>

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by flashcode (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 Aug 2007 09:59:24 AM UTCflashcodeCategoryNone=>display
      Item GroupNone=>display
      StatusNone=>Fixed
      Assigned toNone=>flashcode
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1