bugGChemPaint - Bugs: bug #20706, "use keyboard to change the...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #20706: "use keyboard to change the nature of an atom" Feature fails after modifications

Submitted by:  Takashi Suyama <tak1150>
Submitted on:  Mon 06 Aug 2007 07:22:55 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Jean Bréfort <jean_brefort>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Tue 18 Sep 2007 08:21:36 AM UTC, comment #12:

Closed, but feel free to reopen if the issue reappears.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Mon 03 Sep 2007 06:40:13 AM UTC, comment #11:

Sorry for not posting back for a while.
I have been trying to reproduce this one and it does seem that it is working correctly.
It might have been that the window manager that I was trying out caused it... Anyways, I'm sorry; it seems like a false alarm situation.

Takashi Suyama <tak1150>
Mon 03 Sep 2007 05:39:51 AM UTC, comment #10:

May I consider this one fixed, or do you still have problems?

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Thu 16 Aug 2007 05:41:30 AM UTC, comment #9:

Are you sure that the document window is the active window when you come back to GChemPaint? It must be the active window to make things work, otherwise the key events will go to the active window (which might be the tools box).

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 15 Aug 2007 06:36:14 PM UTC, comment #8:

If I do anything with other programs and come back to Gchempaint, I have to select a structure to and deselect in order to be able to use the key-atom feature.

This is not that big of a deal, but sometimes it can get a bit annoying. Sorry if I'm wining too much :)

Takashi Suyama <tak1150>
Thu 09 Aug 2007 06:30:03 AM UTC, comment #7:

It is the intended behavior. If you type 'o', you get an oxygen, and if you type 'O', you get a menu with all elements with symbols starting with 'O' and accepting the existing bonds. with CapsLock on, the behavior is reversed, which is logical, IMHO.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Wed 08 Aug 2007 08:26:24 PM UTC, comment #6:

I got it to compile ok. Thank you.

With Capslock on, when you type the letter a small menu comes up (ie O and Os for o).

With Capslock off, no menus.

Is this what was intended or bug?
I personally think that it'd be best to have consistency, but I also see convenience in being able to control whether or not to have the menu come up.

Takashi Suyama <tak1150>
Tue 07 Aug 2007 05:43:53 PM UTC, comment #5:

if you are in the top source directory, you must use patch with -p0.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Tue 07 Aug 2007 05:01:07 PM UTC, comment #4:

How do you apply the patch?
I assume I have to do it before compilation?

patch -p1 < 20706.patch

says which file to patch? and I'm not sure what to tell it.
Thanks

Takashi Suyama <tak1150>
Tue 07 Aug 2007 03:49:31 PM UTC, comment #3:

Can you test this patch and tell me if it still does not work on some occasions?

(file #13612)

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Mon 06 Aug 2007 08:29:02 PM UTC, comment #2:

Seems this needs more testing. The function might be unfunctional if the current tool intercepts the keyboard event. The CapsLock issue is confirmed.

Jean Bréfort <jean_brefort>
Project AdministratorIn charge of this item.
Mon 06 Aug 2007 07:54:27 PM UTC, comment #1:

Actually it seems like this bug is more related to CapsLock than copy + paste and undo.

But even without the capslock off, sometimes the feature goes unfunctional.

Takashi Suyama <tak1150>
Mon 06 Aug 2007 07:22:55 PM UTC, original submission:

Ok, I'm on a roll today.

The "use keyboard to change the nature of an atom" feature ceases to work after
1)copy / paste
2)Ctrl + z (undo)

When I press the keyboard, nothing happens.
Also if there are more than 2 molecules, it does not work on the older structure (only works on the molecule that you're working on).

Otherwise the feature works great! Thank you!

Takashi Suyama <tak1150>

 

Attached Files
file #13612:  20706.patch added by jean_brefort (860B - text/x-patch - proposed patch.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jean_brefort (Posted a comment)
  • -unavailable- added by tak1150 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 18 Sep 2007 08:21:36 AM UTCjean_brefortStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 07 Aug 2007 03:49:31 PM UTCjean_brefortAttached File-=>Added 20706.patch, #13612
      StatusConfirmed=>Ready For Test
    Mon 06 Aug 2007 08:29:02 PM UTCjean_brefortStatusNone=>Confirmed
      Assigned toNone=>jean_brefort

    Back to the top


    Powered by Savane 3.1-cleanup1