buglwIP - A Lightweight TCP/IP stack - Bugs: bug #20924, TCPIP_MSG_INPKT packets processing

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #20924: TCPIP_MSG_INPKT packets processing

Submitted by:  Frédéric Bernon <fbernon>
Submitted on:  Tue 28 Aug 2007 06:09:03 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Frédéric Bernon <fbernon>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Wed 29 Aug 2007 07:53:25 AM UTC, comment #2:

Since it's pretty minor, and doesn't change the footprint, I check in the change and close the item. If anyone is no agree, no problem, we can reopen it...

Frédéric Bernon <fbernon>
Project MemberIn charge of this item.
Tue 28 Aug 2007 07:05:59 PM UTC, comment #1:

Looks good to me. Thanks Frédéric.

Jonathan Larmour <jifl>
Project Member
Tue 28 Aug 2007 06:09:03 PM UTC, original submission:

Since last changes for TCPIP_MSG_INPKT, there could be a problem with network interfaces like loopif which enqueue with tcpip_input IP packets, and not Ethernet packets. The patch fix this problem by checking if the netif got the NETIF_FLAG_ETHARP flag: in this case, packets are considered like Ethernet packets, else, they are considered like IP packets. No objects to check in (I think it's ok for Jonathan - as he propose me this solution on IRC, and Marc)?

Note the code is disabled if LWIP_ARP=0 to reduce footprint...

Frédéric Bernon <fbernon>
Project MemberIn charge of this item.

 

Attached Files
file #13824:  TCPIP_MSG_INPKT.patch added by fbernon (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jifl (Posted a comment)
  • -unavailable- added by fbernon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 29 Aug 2007 07:53:25 AM UTCfbernonStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Tue 28 Aug 2007 06:09:03 PM UTCfbernonAttached File-=>Added TCPIP_MSG_INPKT.patch, #13824

    Back to the top


    Powered by Savane 3.1-cleanup1