bugAVR C Runtime Library - Bugs: bug #2111, Enhancement of code in sfr_defs.h

 
 

bug #2111: Enhancement of code in sfr_defs.h

Submitted by:  None
Submitted on:  Thu 02 Jan 2003 05:36:03 PM UTC  
 
Category: HeaderSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: FixedPercent Complete: 0%
Assigned to: Joerg Wunsch <joerg_wunsch>Originator Email: -unavailable-
Open/Closed: ClosedRelease: None
Fixed Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Jan 2003 10:01:59 PM UTC, comment #1:

Fixe applied in revision 1.7 of include/avr/sfr_defs.h.

Thanks for the fix!

Joerg Wunsch <joerg_wunsch>
Project AdministratorIn charge of this item.
Thu 02 Jan 2003 05:36:03 PM UTC, original submission:

In sfr_defs.h, the bit_is_clear macro is declared as follow:
#define bit_is_clear(sfr, bit) (~inb(sfr) & _BV(bit))

If I watch code generated by compiler, the code is not sufficient. But
with this macro the size of code is decreazed (I ve just tested that on atmega target).

#define bit_is_clear(sfr,bit) !bit_is_set(sfr,bit)

Have you the same results and do you think it's interesting to replace the old version with this version ?

Best regards

Frantz

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 06 Jan 2003 10:01:59 PM UTCjoerg_wunschStatusNone=>(Error - Not Found)
  Open/ClosedOpen=>(Error - Not Found)
Mon 06 Jan 2003 09:59:57 PM UTCjoerg_wunschAssigned toNone=>NA

Back to the top


Powered by Savane 3.1-cleanup1