bugGluster - Bugs: bug #21259, [Patch] unify translater returns...

 
 

bug #21259: [Patch] unify translater returns incorrect stats when underlying filesystems have different block sizes

Submitted by:  ronald <roadrunner>
Submitted on:  Fri 05 Oct 2007 03:23:44 AM UTC  
 
Category: GlusterFSSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Improper behaviour
Status: FixedPrivacy: Public
Assigned to: Amar Tumballi <amarts>Originator Name: 
Open/Closed: ClosedRelease: 
Operating System: GNU/LinuxReproducibility: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 05 Oct 2007 05:27:02 AM UTC, comment #1:

Thanks for the patch, It was surely improper behavior and was in my TODO list from long time. Applied the patch.

Amar Tumballi <amarts>
Project MemberIn charge of this item.
Fri 05 Oct 2007 03:23:44 AM UTC, original submission:

GlusterFS 1.3.3

The unify translator just sums up the f_blocks, f_bfree, and
f_bavail fields from the subvolumes without regards to the
f_bsize and f_frsize fields. If the volumes have different
block sizes then the results are quite wrong.

Attached is a patch to fix this. It's not quite clear to me
whether the max or the min of the block-sizes should be chosen,
so I chose the max - this gives slightly less accurate results
for the number of free and available blocks, but is better if a
client uses the f_bsize in order to determine block sizes for
reading and writing.

ronald <roadrunner>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #14085:  gfs_unify_stat.patch added by roadrunner (2KiB - text/x-patch - Patch to fix statvfs results.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by amarts (Posted a comment)
  • -unavailable- added by roadrunner (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 05 Oct 2007 05:27:02 AM UTCamartsStatusNone=>Fixed
      Assigned toNone=>amarts
      Open/ClosedOpen=>Closed
    Fri 05 Oct 2007 03:23:44 AM UTCroadrunnerAttached File-=>Added gfs_unify_stat.patch, #14085

    Back to the top


    Powered by Savane 3.1-cleanup1