bugMicrosoft NTLM authentication library - Bugs: bug #21288, Segfault in test suite

 
 

bug #21288: Segfault in test suite

Submitted by:  None
Submitted on:  Mon 08 Oct 2007 08:38:44 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 05 Mar 2008 12:00:17 PM UTC, comment #3:

This should be closed with just released v0.4.2. Closing, but if it doesn't work let's re-open the bug.

Thanks.

Simon Josefsson <jas>
Project Administrator
Wed 05 Mar 2008 10:39:12 AM UTC, comment #2:

Hi! Sorry for the slow response, I had forgotten about this bug tracker.

I think the patch is incorrect -- the bufIndex variable should be stored in host-endian order to simplify things.

Your patch uses WORDS_BIGENDIAN and functions like byteswap16 from the public header file, neither are guaranteed to be properly declared.

The only place where bufIndex isn't treated as a host-endian integer is in the self test, and that is the reason the self test fails. In other words, the self test was buggy.

I have tested the attached patch on sparc, and it solved the problem. Please test it.

I'll release 0.4.2 shortly with this and other fixes.

Thanks.

(file #15185)

Simon Josefsson <jas>
Project Administrator
Fri 29 Feb 2008 03:46:44 PM UTC, comment #1:

Indeed SmbLength is dependend on the byteorder, among at least two other places. This is cared for in the attached patch. Verified under Solaris 10 Sparc.

(file #15145)

Dagobert Michelsen <dagobert>
Mon 08 Oct 2007 08:38:44 AM UTC, original submission:

Hello,

please have a look at Gentoo bug 194282 (https://bugs.gentoo.org/show_bug.cgi?id=194282).

It appears that some architectures experience segmentation fault in test_ntlm program, shipped with libntlm source and used in test suite. Only architectures which reported the issue so far are ppc and sparc/sparc64, all of which are big-endian, which might or might not be just a coincidence.

Feel free to join the discussion or ask for more info on abovementioned bug, if it's not too much of an inconvenience.

Thanks,
Andrej

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15185:  foo added by jas (762B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jas (Updated the item)
  • -unavailable- added by dagobert (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 05 Mar 2008 12:00:17 PM UTCjasStatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Wed 05 Mar 2008 10:39:12 AM UTCjasAttached File-=>Added foo, #15185
    Fri 29 Feb 2008 03:46:44 PM UTCdagobertAttached File-=>Added patch-byteorder-bigendian.diff, #15145

    Back to the top


    Powered by Savane 3.1-cleanup1