buglwIP - A Lightweight TCP/IP stack - Bugs: bug #21291, tcp_pcb_remove

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #21291: tcp_pcb_remove

Submitted by:  Oleg Tyshev <olegreen>
Submitted on:  Mon 08 Oct 2007 11:55:25 AM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Change RequestStatus: Invalid
Privacy: PublicAssigned to: None
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Mon 29 Oct 2007 03:41:42 PM UTC, comment #2:

You can close this bug report.
I have read the code... and didn't noticed
pcb->flags &= ~TF_ACK_DELAY;
I can't remember have I seen ACK really in wireshark or not.

Oleg Tyshev <olegreen>
Sun 28 Oct 2007 05:40:43 PM UTC, comment #1:

Did you actually see an ACK being sent after receiving a RST or does this bug item come from reading the code?

I tried to reproduce this bug and found the code is somewhat hard to read there: tcp_pcb_remove only sends an ACK if TF_ACK_DELAY is set in pcb->flags. But exactly that won't happen when receiving a RST because the flag is removed in tcp_process when receiving a RST!

Nevertheless, in wireshark, I was seeing an ACK sent from my lwIP machine after receiving a RST but that turned out to be the ACK for the FIN the windows side sent before.

Could you please give some more information or test again? Otherwise, I'll close this as invalid.

Simon Goldschmidt <goldsimon>
Project Administrator
Mon 08 Oct 2007 11:55:25 AM UTC, original submission:

Function tcp_pcb_remove() check herself TCP state and if it
LISTEN or TIME_WAIT don't send delayed ACK.
For case when packet with RST flag processed this function should not send ACK too.
It is better to add extra bool parameter to function to control sending ACKs.

Oleg Tyshev <olegreen>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by fbernon (Updated the item)
  • -unavailable- added by goldsimon (Posted a comment)
  • -unavailable- added by olegreen (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 29 Oct 2007 05:23:37 PM UTCfbernonStatusNone=>Invalid
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1