bugCERTI - Bugs: bug #21399, Some CERTI (obsolete) builtin...

 
 

bug #21399: Some CERTI (obsolete) builtin buffer size may needs adjustment

Submitter:  Eric NOULARD <erk>
Submitted:  Tue 23 Oct 2007 01:37:50 PM UTC
 
Category:  CERTI Severity:  * 3 - Normal
Item Group:  Software error Status:  Fixed
Privacy:  Public Assigned to:  rousse
Open/Closed:  Closed Release:  * 3.2.4
Reproducibility:  None Fixed Release:  * 3.3.0
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Sun 09 Dec 2007 05:06:04 PM UTC, comment #2: 

This issue is currently addressed by Jean-Yves.

Eric NOULARD <erk>
Project Administrator
Thu 25 Oct 2007 09:01:01 PM UTC, comment #1: 

I think we may welle
get rid of most (if not ALL) the constant
first 5 or 6 of them are used to size
string represented by a char array.
We may replace those by an std::string
and use

std::string::c_str() when needed
of course this implies dynamic allocation
but those string are used sparingly and as far as saw
not in time critical tight simulation loop.

I will try this.
I linked this bug to other related bug.

Eric NOULARD <erk>
Project Administrator
Tue 23 Oct 2007 01:37:50 PM UTC, original submission:  

Current CERTI version
still use deprecated statically sized object
whose size is driven by the following constants
(see certi/include/certi.hh) see hereafter.

Users may need to change the default value
depending on the size of the object exchanged
by his federation.
If any those values are changed, one should
recompile CERTI.

The most important values are:
#define MAX_BYTES_PER_VALUE 150
#define MAX_USER_TAG_LENGTH 32
#define BUFFER_SIZE_DEFAULT 236

The RTI should throw RTIinternalError
if any operation would need more than
those size.

We should implement dynamic sizing of buffer.

// Deprecated HLA macros still in use
#define MAX_BYTES_PER_VALUE 150
#define MAX_FEDERATE_NAME_LENGTH 64
#define MAX_FEDERATION_NAME_LENGTH 64
#undef MAX_USER_TAG_LENGTH
#define MAX_USER_TAG_LENGTH 64
#undef MAX_ATTRIBUTES_PER_CLASS
#define MAX_ATTRIBUTES_PER_CLASS 20
#define MAX_BYTES_PER_VALUETYPE 20
#undef MAX_PARAMETERS_PER_CLASS
#define MAX_PARAMETERS_PER_CLASS 20
#define MAX_FEDFILE_NAME_LENGTH 100

// next used in MessageBody constructor with no size
// EN. change from 200-->236 because HeaderStruct is 36
//     see MessageBody code for reason
#define BUFFER_SIZE_DEFAULT 236
// next used in RTIG::processIncomingMessage method
#define BUFFER_EXCEPTION_REASON_SIZE 256

Eric NOULARD <erk>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Carbon-Copy List
  • -email is unavailable- added by erk (Submitted the item)
  • -email is unavailable- added by erk (Encountered the same bug)
  •  

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-07-02 erk StatusNone Fixed
        Open/ClosedOpen Closed
        Fixed ReleaseUnknown 3.3.0
    2008-05-24 erk Dependencies- bugs #23329 is dependent
    2007-12-09 erk Assigned toerk rousse
    2007-10-25 erk Assigned toNone erk
        Dependencies- Depends on bugs #21423
        Dependencies- Depends on bugs #19685
    2007-10-23 erk Carbon-Copy- Added patricecarle

    Back to the top


    Powered by Savane 3.9