bugmonotone - Bugs: bug #21453, monotone-server scripts are run by...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #21453: monotone-server scripts are run by /bin/sh, but use bash features

Submitted by:  Glen Ditchfield <gjditchfield>
Submitted on:  Mon 29 Oct 2007 03:40:42 AM UTC  
 
Category: networkingSeverity: 3 - Normal
Item Group: crashStatus: Fixed
Privacy: PublicAssigned to: Zack Weinberg <zwol>
Open/Closed: Closed
mtn version --full: 

monotone 0.36 (base revision: e4bc808d89e029ce623f9e8f2b10c84006b83fb5)

Mon 05 Nov 2007 03:24:23 AM UTC, comment #3:

On all supported Ubuntu releases, /usr/bin/perl is in the perl-base package, which is in the "base" section: see http://packages.ubuntu.com/dapper/

bash is in the base section, too. You could also generate a random password with something like "head -c4 /dev/random | md5sum", since they are in the base coreutils package.

Glen Ditchfield <gjditchfield>
Sun 04 Nov 2007 08:01:58 PM UTC, comment #2:

Will be fixed in Debian 0.37-2 and upstream 0.38.

Zack Weinberg <zwol>
Project MemberIn charge of this item.
Fri 02 Nov 2007 04:53:43 AM UTC, comment #1:

I'm looking into fixing this for the official Debian-sourced packages and ultimately for 0.38. I'd prefer to make both the .config and .postinst scripts work with dash as /bin/sh. Can you tell me whether perl (just /usr/bin/perl, no modules) is provided by an Essential package in Ubuntu? I know they were trying to minimize its use.

Zack Weinberg <zwol>
Project MemberIn charge of this item.
Mon 29 Oct 2007 03:40:42 AM UTC, original submission:

I built a monotone-server package on Ubuntu Feisty Fawn, starting from the scripts in the 0.36 release's debian directory. When I installed it I found a few small problems. The scripts start with the usual "#!/bin/sh" line, but on Unbuntu /bin/sh is a link to the small Posix-ish shell "dash", which does not support some of the Bash constructs that the scripts use:

- monotone-server.config uses $RANDOM, which dash doesn't support. I changed the first line to "#!/bin/bash".

- monotone-server.postinst uses the "function" keyword to declare functions (unlike monotone-server.config, which leaves the keyword out of function declarations). I deleted the keywords.

Glen Ditchfield <gjditchfield>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by zwol (Posted a comment)
  • -unavailable- added by gjditchfield (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 04 Nov 2007 08:01:58 PM UTCzwolItem GroupNone=>crash
      StatusNone=>Fixed
      Assigned toNone=>zwol
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1