bugThe FreeType Project - Bugs: bug #21485, Null pointer / redundant code in...

 
 

bug #21485: Null pointer / redundant code in sfnt_done_face

Submitted by:  Ian Wood <ianjwood>
Submitted on:  Wed 31 Oct 2007 11:17:26 AM UTC  
 
Severity: 3 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.6

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 01 Nov 2007 09:21:06 AM UTC, comment #1:

The second check was missing. Thanks for the report;
it's now fixed in the CVS.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Wed 31 Oct 2007 11:17:26 AM UTC, original submission:

The function sfnt_done_face in freetype2/sfnt/sfobjs.c uses the sfnt pointer at two seperate points.

The first (sfobjs.c, Line 989) first checks whether the pointer is not null. The second at 1054 does not.

As far as I can see tt_face_done & cff_face_done check sfnt is not null before callinf sfnt_done_face.

Is the if statement at line 989 not required or is an extra one required at 1054?

Ian Wood <ianjwood>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by ianjwood (Submitted the item)
  • -unavailable- added by ianjwood
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 01 Nov 2007 09:21:06 AM UTCwlStatusNone=>Fixed
      Assigned toNone=>wl
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.3.6
    Wed 31 Oct 2007 11:17:26 AM UTCianjwoodCarbon-Copy-=>Added ianjwood

    Back to the top


    Powered by Savane 3.1-cleanup1