buglwIP - A Lightweight TCP/IP stack - Bugs: bug #21491, TCP MSS sent is based on the...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #21491: TCP MSS sent is based on the received MSS option

Submitted by:  Simon Goldschmidt <goldsimon>
Submitted on:  Thu 01 Nov 2007 04:02:07 PM UTC  
 
Category: TCPSeverity: 3 - Normal
Item Group: Faulty BehaviourStatus: Fixed
Privacy: PublicAssigned to: Simon Goldschmidt <goldsimon>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Thu 01 Nov 2007 04:49:54 PM UTC, comment #3:

Fixed since I opened another bug report for pcb->mss = 536 when no MSS option received.

I'm still leaving this open for a while or until receiving comments :-)

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 01 Nov 2007 04:25:18 PM UTC, comment #2:

Since we already discussed that on the devel list a little, I'm checked in the change for building the MSS option using TCP_MSS instead of pcb->mss.

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 01 Nov 2007 04:15:50 PM UTC, comment #1:

Forgot: When no MSS option is received, the MSS used for pcb->mss should be 536.

This is related to this bug because the way it is now (MSS option sent is built using pcb->mss), the MSS options sent would be 536 if no MSS option was received (since right now, sent MSS equals received MSS on passive open).

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.
Thu 01 Nov 2007 04:02:07 PM UTC, original submission:

Currently, the MSS option sent in tcp_connect (active open) and tcp_listen_input (passive open) is based on pcb->mss instead of TCP_MSS.

While in tcp_connect, this is is OK (because pcb->mss is set to TCP_MSS just before), this leads to advertising the remote MSS in tcp_listen_input.

I'd make this a define TCP_BUILD_MSS_OPTION() (that's based on TCP_MSS) in both cases, which also removes redundant source code.

Any objections?

Simon Goldschmidt <goldsimon>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by goldsimon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 11 Nov 2007 11:45:13 AM UTCgoldsimonOpen/ClosedOpen=>Closed
    Thu 01 Nov 2007 04:49:54 PM UTCgoldsimonStatusNone=>Fixed
      Assigned toNone=>goldsimon

    Back to the top


    Powered by Savane 3.1-cleanup1