bugAVR C Runtime Library - Bugs: bug #22276, wdt_reset fails with devices with...

 
 

bug #22276: wdt_reset fails with devices with large WDTCSR addresses

Submitted by:  Dean Camera <abcminiuser>
Submitted on:  Sun 10 Feb 2008 01:14:02 PM UTC  
 
Category: HeaderSeverity: 4 - Important
Priority: 9 - ImmediateItem Group: libc code
Status: FixedPercent Complete: 100%
Assigned to: Eric Weddington <arcanum>Open/Closed: Closed
Release: 1.6.2Fixed Release: 1.7.0

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Wed 20 Aug 2008 01:04:36 PM UTC, comment #6:

The current state of wdt.h will either generate STS or OUT instructions depending on the device. Closing bug.

Dean, let me know if there are further issues.

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Thu 20 Mar 2008 05:55:15 PM UTC, comment #5:

Reopening bug.

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Thu 20 Mar 2008 01:56:20 AM UTC, comment #4:

The changes you made will not work unless you get '_WDT_CONTROL_REG' into something you can test in this line-

#if (_WDT_CONTROL_REG > 0x5F)

which is why I surrounded that with temporarily redefining _MMIO_BYTE, so that test could be made.

Maybe there is a better way to end up with a number that can be tested, I don't know.

CurtVM <curtvm>
Mon 17 Mar 2008 05:15:06 PM UTC, comment #3:

Fixed using CurtVM's suggestion of checking for the location of the watchdog register. This removes the need to keep a list of devices in the header file.

@CurtVM: I did not add the other watchdog interrupt features that you have in your version of this file. This would be a significant enough of a change that I would rather you submit that separately, preferably as a patch.

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Mon 18 Feb 2008 09:47:46 PM UTC, comment #2:

May I suggest changing the wdt.h in a way that does not depend on having a list of avr's in the file.

I have done a little work on wdt.h-
http://www.mtcnet.net/~henryvm/wdt/

I just check whether the watchdog register is in the IN/OUT or LDS/STS area, then use the appropriate instructions.

I also added the watchdog interrupt features included with newer avr's.

Just a suggestion.

Thanks.

CurtVM <curtvm>
Sun 10 Feb 2008 07:16:04 PM UTC, comment #1:

Hi Dean,

Could you possibly put together a list of affected devices? That would be helpful in getting this resolved quickly.

Thanks,
Eric

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Sun 10 Feb 2008 01:14:02 PM UTC, original submission:

avr-lib-c's wdt_disable() function silently fails with AVRs (such as the AT90USB1287) that have their WDTCSR registers located outside the range of the OUT instruction that the inline assembly function uses. This results in the watchdog being left on at runtime.

Dean Camera <abcminiuser>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by curtvm (Posted a comment)
  • -unavailable- added by arcanum (Posted a comment)
  • -unavailable- added by abcminiuser (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 15 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 20 Aug 2008 01:04:36 PM UTCarcanumStatusNone=>Fixed
      Percent Complete50%=>100%
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>1.7.0
    Mon 11 Aug 2008 02:53:30 AM UTCarcanumSeverity3 - Normal=>4 - Important
      Priority5 - Normal=>9 - Immediate
    Wed 18 Jun 2008 08:05:17 PM UTCarcanumStatusFixed=>None
      ReleaseNone=>1.6.2
    Thu 20 Mar 2008 05:55:15 PM UTCarcanumPercent Complete100%=>50%
      Open/ClosedClosed=>Open
    Mon 17 Mar 2008 05:15:06 PM UTCarcanumStatusNone=>Fixed
      Percent Complete0%=>100%
      Assigned toNone=>arcanum
      Open/ClosedOpen=>Closed
    Mon 17 Mar 2008 05:15:05 PM UTCarcanumCategoryLibrary=>Header

    Back to the top


    Powered by Savane 3.1-cleanup1