buggnokii - Bugs: bug #22611, invalid vcard generation

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #22611: invalid vcard generation

Submitter:  None
Submitted:  Sun 16 Mar 2008 08:40:01 AM UTC
Votes: 1
 
Category:  gnokii Severity:  3 - Normal
Item Group:  major malfunction Status:  Fixed
Privacy:  Public Assigned to:  dforsi
Open/Closed:  Closed

Wed 04 Jun 2008 01:15:57 PM UTC, comment #5: 

gnokii versions fixed thanks to your bug report never create vCards with underscores in property names.

The code at lines 264..275 of common/vcard.c,v 1.33 is used for compatibility with vCards containing underscores that were generated by earlier gnokii versions and is bracketed with #if #endif for easy removal at a later time. This should allow the use of fixed gnokii versions for restoring vCards generated with broken gnokii versions; this also allows the use of convert_phonebook.c from gnokii-extras to fix vCard files without using a phone.

You may reopen this bug right now to ask removal of that compatibility code, but it would be wise to keep it for many months (or forever).

Daniele Forsi <dforsi>
Group administrator
Wed 04 Jun 2008 12:19:26 PM UTC, comment #4: 

There is still code in the Subversion repository which contains vCard properties with underscores (common/vcard.c). Is this code still in use? If it is, I propose to re-open this bug until it has been completely fixed.

Victor Engmark <l0b0>
Sat 12 Apr 2008 04:31:09 PM UTC, comment #3: 

I replaced the underscores with hyphens in gn_phonebook2vcard() and made it always output the "N:" property, as pointed out in the original submission. When there is no information about first/last name the contents of "N:" are the same as "FN:" because this is a low level function (it should be the phone or the user to  indicate what is what).
Note that we splitted X_GSM_STORE_AT in two properties, X-GSM-MEMORY and X-GSM-LOCATION and X-GSM-CALLERGROUP:5 is correctly associated with CATEGORIES:None instead of CATEGORIES:Unknown.

I also added code to gn_vcard2phonebook() to parse the "N:" property on import, as reported in the following comments. When both "N:" and "FN:" are present libgnokii stores both; results with different drivers/phones may vary and may need more testing.

Thank you for your reports.

Daniele Forsi <dforsi>
Group administrator
Wed 19 Mar 2008 10:50:53 AM UTC, comment #2: 

I'm sorry, that should be "first name", not "last name".

Victor Engmark <l0b0>
Wed 19 Mar 2008 10:50:01 AM UTC, comment #1: 

For my Nokia 6300 it correctly outputs the "N" value if and only if a last name has been specified for the contact:
N:Doe;John;;;

However, import of the "N" value does not work.

Victor Engmark <l0b0>
Sun 16 Mar 2008 08:40:01 AM UTC, original submission:  

zodman@cosmogirl:~$ gnokii --config gnokiirc --identify
GNOKII Version 0.6.23
IMEI         : 356204000476307
Manufacturer : NOKIA
Model        : RH-68
Product name : RH-68
Revision     : SW 6.0540.0, HW 256


I have import some vcards from my cel (nokia 6670) with gnokii and gnapplet
and convert it to vcard list file.
nokii --config gnokiirc --getphonebook ME 2 end -vcard

BEGIN:VCARD
VERSION:3.0
FN:Gnuget david
TEL;TYPE=PREF,VOICE:5520275185
X_GSM_STORE_AT:ME6
X_GSM_CALLERGROUP:5
CATEGORIES:Unknown
TEL;TYPE=CELL:5520275185
END:VCARD

BEGIN:VCARD
VERSION:3.0
FN:K001
TEL;TYPE=PREF,VOICE:9626059782
X_GSM_STORE_AT:ME9
X_GSM_CALLERGROUP:5
CATEGORIES:Unknown
TEL;TYPE=CELL:9626059782
TEL;TYPE=CELL:9982126568
END:VCARD

BEGIN:VCARD
VERSION:3.0
FN:Ciruz
TEL;TYPE=PREF,VOICE:9991343435
X_GSM_STORE_AT:ME17
X_GSM_CALLERGROUP:5
CATEGORIES:Unknown
TEL;TYPE=VOICE:9991343435
END:VCARD

BEGIN:VCARD
VERSION:3.0
FN:Aisha
TEL;TYPE=PREF,VOICE:9991797167
X_GSM_STORE_AT:ME70
X_GSM_CALLERGROUP:5
CATEGORIES:Unknown
TEL;TYPE=VOICE:9991797167
EMAIL;TYPE=INTERNET:monique_aisha@hotmail.com
END:VCARD

vCard's are NOT valid.  RFC2426 is quite clear that both the FN and N properties MUST be present in a vCard.  These contain an FN but not an N.

and

RFC 2426 is explicit that names consist only of letters, numbers and hyphens.  The parameters X_GSM_STORE_AT and X_GSM_CALLERGROUP should be X-GSM-STORE-AT and X-GSM-CALLERGROUP.
=================0

zodman@cosmogirl:~$ gnokii --version
GNOKII Version 0.6.23
....
Built 02:34:08 Mar 16 2008

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dforsi (Posted a comment)
  • -email is unavailable- added by l0b0 (Voted in favor of this item)
  • -email is unavailable- added by l0b0 (Posted a comment)
  • -email is unavailable- added by l0b0
  •  

    There is 1 vote so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-04-12 dforsi StatusNone Fixed
        Assigned toNone dforsi
        Open/ClosedOpen Closed
    2008-03-19 l0b0 Carbon-Copy- Added l0b0
    2008-03-19 l0b0 Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code