gnokii - Bugs: bug #22611, invalid vcard generation
You are not allowed to post comments on this tracker with your current authentication level.
bug #22611: invalid vcard generation
Submitter: | None | ||
Submitted: | Sun 16 Mar 2008 08:40:01 AM UTC | ||
Votes: | 1 | ||
Category: | gnokii | Severity: | 3 - Normal |
Item Group: | major malfunction | Status: | Fixed |
Privacy: | Public | Assigned to: | dforsi |
Open/Closed: | Closed |
Wed 04 Jun 2008 01:15:57 PM UTC, comment #5: |
Daniele Forsi <dforsi> |
Wed 04 Jun 2008 12:19:26 PM UTC, comment #4: There is still code in the Subversion repository which contains vCard properties with underscores (common/vcard.c). Is this code still in use? If it is, I propose to re-open this bug until it has been completely fixed. |
Victor Engmark <l0b0> |
Sat 12 Apr 2008 04:31:09 PM UTC, comment #3: I replaced the underscores with hyphens in gn_phonebook2vcard() and made it always output the "N:" property, as pointed out in the original submission. When there is no information about first/last name the contents of "N:" are the same as "FN:" because this is a low level function (it should be the phone or the user to indicate what is what).
|
Daniele Forsi <dforsi> |
Wed 19 Mar 2008 10:50:53 AM UTC, comment #2: I'm sorry, that should be "first name", not "last name". |
Victor Engmark <l0b0> |
Wed 19 Mar 2008 10:50:01 AM UTC, comment #1: For my Nokia 6300 it correctly outputs the "N" value if and only if a last name has been specified for the contact:
|
Victor Engmark <l0b0> |
Sun 16 Mar 2008 08:40:01 AM UTC, original submission:
zodman@cosmogirl:~$ gnokii --config gnokiirc --identify
|
Anonymous |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There is 1 vote so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-04-12 | dforsi | Status | None | Fixed | |
Assigned to | None | dforsi | |||
Open/Closed | Open | Closed | |||
2008-03-19 | l0b0 | Carbon-Copy | - | Added l0b0 | |
2008-03-19 | l0b0 | Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-758e.
Corresponding source code
gnokii versions fixed thanks to your bug report never create vCards with underscores in property names.
The code at lines 264..275 of common/vcard.c,v 1.33 is used for compatibility with vCards containing underscores that were generated by earlier gnokii versions and is bracketed with #if #endif for easy removal at a later time. This should allow the use of fixed gnokii versions for restoring vCards generated with broken gnokii versions; this also allows the use of convert_phonebook.c from gnokii-extras to fix vCard files without using a phone.
You may reopen this bug right now to ask removal of that compatibility code, but it would be wise to keep it for many months (or forever).