buglwIP - A Lightweight TCP/IP stack - Bugs: bug #22613, IGMP iphdr problem

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #22613: IGMP iphdr problem

Submitted by:  Frédéric Bernon <fbernon>
Submitted on:  Sun 16 Mar 2008 10:37:41 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Frédéric Bernon <fbernon>
Open/Closed: ClosedPlanned Release: None
lwIP version: None

Mon 17 Mar 2008 01:43:54 PM UTC, comment #5:

Ok, it's good for me. I have check in (with "pack" macros). I close this one.

About adding rtp in contrib/apps, I will post a mail in the mailing list.

Frédéric Bernon <fbernon>
Project MemberIn charge of this item.
Mon 17 Mar 2008 01:31:32 PM UTC, comment #4:

Good. I do my own test on my target, and next, I check in igmp changes.

Frédéric Bernon <fbernon>
Project MemberIn charge of this item.
Mon 17 Mar 2008 01:04:54 PM UTC, comment #3:

Frederic,

I ran your patch with my application and BIG_ENDIAN hardware this morning. My application runs fine and the IGMP IP headers look good with WireShark.

Thanks again...
Ed

Ed Kerekes <edkerekes>
Mon 17 Mar 2008 12:44:25 AM UTC, comment #2:

Frederic,
Thanks I have applied your patch, compiled and desk checked it.
I will check it out with my application and hardware in the morning.

Also, I agree with your suggestion for adding the igmp_msg structure. My system doesn't require it, but is seems like a good idea.

Ed

Ed Kerekes <edkerekes>
Sun 16 Mar 2008 05:41:35 PM UTC, comment #1:

I have implement a small and basic rtp client/server (no real processing, just an mpeg4 image sent, and the client check "sequence number" to see if there is some lost packets). Like this, we can test the multicast features in lwIP (it is based on socket layer, like this, all layers are tested). With it, I have test the patch I proposed, and it seems ok.

I attach it here the rtp.zip file, and I would like to add it to contrib. Is there any objections?

Last, I think we should add...

#ifdef PACK_STRUCT_USE_INCLUDES
# include "arch/bpstruct.h"
#endif
PACK_STRUCT_BEGIN
...
PACK_STRUCT_STRUCT;
PACK_STRUCT_END
#ifdef PACK_STRUCT_USE_INCLUDES
# include "arch/epstruct.h"
#endif

around struct igmp_msg. Comments?

(file #15279)

Frédéric Bernon <fbernon>
Project MemberIn charge of this item.
Sun 16 Mar 2008 10:37:41 AM UTC, original submission:

See Edward Kerekes's post :

http://lists.nongnu.org/archive/html/lwip-devel/2008-03/msg00024.html

In few words, some fields should be fixed on IGMP messages's ip headers.

I propose an alternative patch using ip.h macros (I think it's more in lwIP spirit). I can't test it before tomorrow, but I think it could/should go in 1.3.0.

Frédéric Bernon <fbernon>
Project MemberIn charge of this item.

 

Attached Files
file #15279:  rtp.zip added by fbernon (28KiB - application/x-zip)
file #15275:  igmp.patch added by fbernon (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by edkerekes (Posted a comment)
  • -unavailable- added by fbernon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 17 Mar 2008 01:43:54 PM UTCfbernonStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 16 Mar 2008 05:41:35 PM UTCfbernonAttached File-=>Added rtp.zip, #15279
      StatusIn Progress=>Ready For Test
      Planned Release=>1.3.0
    Sun 16 Mar 2008 10:37:41 AM UTCfbernonAttached File-=>Added igmp.patch, #15275

    Back to the top


    Powered by Savane 3.1-cleanup1