bugGlobulation 2 - Bugs: bug #22719, missing check if maps/games...

 
 

bug #22719: missing check if maps/games differ(?)

Submitted by:  Leo Wandersleb <giszmo>
Submitted on:  Mon 24 Mar 2008 10:30:48 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: NoneOperating System: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 31 Mar 2008 03:44:40 AM UTC, comment #4:

Just tested. It works perfectly now. Nice job.

Kieran <k776>
Project Administrator
Mon 31 Mar 2008 02:43:57 AM UTC, comment #3:

I've changed from using md5 to sha1.

Bradley Arsenault <genixpro>
Project Administrator
Thu 27 Mar 2008 12:12:51 AM UTC, comment #2:

with the attached maps we get no transfere even as the files differ. maybe the check nct committed to "default" recently would have stopped us from starting that game but to me it proves more practical to calculate some md5 of the whole file than to rely on the game state checksum to be correct.

(file #15350)

Leo Wandersleb <giszmo>
Project Member
Tue 25 Mar 2008 12:25:40 AM UTC, comment #1:

I have added the maps checksum to the MapHeader, so it is compared when the file is sent across the network.

Bradley Arsenault <genixpro>
Project Administrator
Mon 24 Mar 2008 10:30:48 PM UTC, original submission:

as starting an autosavegame happened without any map beeing transfered and we get an instant desync we guess the files are not compared close enough. Either the autosavegame should store the checksum and compare it or even cleaner and more secure all clients calculate a checksum of the file and decide on this if the map/game has to be transmitted.

Leo Wandersleb <giszmo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15350:  SameChecksumWeGuess.tar.gz added by giszmo (212KiB - application/x-gzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by k776 (Posted a comment)
  • -unavailable- added by genixpro (Posted a comment)
  • -unavailable- added by giszmo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 31 Mar 2008 03:44:40 AM UTCk776StatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 27 Mar 2008 12:12:51 AM UTCgiszmoAttached File-=>Added SameChecksumWeGuess.tar.gz, #15350
    Tue 25 Mar 2008 12:25:40 AM UTCgenixproStatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup1