bugCERTI - Bugs: bug #22821, Infinite LBTS <--> infinite...

 
 

bug #22821: Infinite LBTS <--> infinite RTIfedTime conversion error

Submitted by:  Petr Gotthard <gotthardp>
Submitted on:  Thu 03 Apr 2008 11:05:54 AM UTC  
 
Category: CERTISeverity: 4 - Important
Item Group: Software errorStatus: Ready For Test
Privacy: PublicAssigned to: Eric NOULARD <erk>
Open/Closed: ClosedRelease: 3.2.6
Reproducibility: NoneFixed Release: 3.2.7

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 07 Apr 2008 03:10:52 PM UTC, comment #2:

This patch seems OK for me.
He passed my own (small test).

The patch did reach CVS:
commitid: NmoLYWDTQzNSMbYs

Thank you very much Petr.

Eric NOULARD <erk>
Project AdministratorIn charge of this item.
Thu 03 Apr 2008 02:57:39 PM UTC, comment #1:

Attached is a proposed patch for this issue.

Implementing infitite numbers by using RTI::Double _positiveInfinity as a boolean looks strange. I might found a reason why the standards propose the _zero, _epsilon and _positiveInfinite. See the patch.

(file #15398)

Petr Gotthard <gotthardp>
Project Member
Thu 03 Apr 2008 11:05:54 AM UTC, original submission:

Infinite LBTS is implemented using double value set to DBL_MAX, while infinite FedTime is implemented by infinity indicator.
The LBTS is stored as double, but queryLBTS returns it as FedTime, so a double <--> FedTime conversion is used.

The FedTime doesn't correctly convert infinite double values, so FedTime::isPositiveInfinite() doesn't work correctly after initializing it with infinite double. (And vice versa, FedTime::getTime() doesn't return infinite double when the infinity indicator is set.)

Suggestion:
- double <--> FedTime conversion should work for infinite values
- std::numeric_limits<double>::infinity() should be used to represent infinity

Petr Gotthard <gotthardp>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15398:  infi.patch added by gotthardp (5KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by erk (Posted a comment)
  • -unavailable- added by gotthardp (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 26 Apr 2008 03:26:06 PM UTCerkOpen/ClosedOpen=>Closed
    Sat 26 Apr 2008 03:25:47 PM UTCerkFixed ReleaseCVS=>3.2.7
    Mon 07 Apr 2008 03:10:52 PM UTCerkStatusNone=>Ready For Test
      Assigned toNone=>erk
      ReleaseCVS=>3.2.6
      Fixed ReleaseUnknown=>CVS
    Thu 03 Apr 2008 02:57:39 PM UTCgotthardpAttached File-=>Added infi.patch, #15398

    Back to the top


    Powered by Savane 3.1-cleanup1