bugyauap - commandline audio player - Bugs: bug #22977, sound distortion when adjusting...

 
 

bug #22977: sound distortion when adjusting amarok's volume

Submitted by:  None
Submitted on:  Fri 18 Apr 2008 09:15:26 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sun 05 Oct 2008 06:54:26 PM UTC, comment #8:

Sorry that this took so long but the bug should be fixed in 0.2.3.

Sascha Sommer <faust3>
Project Administrator
Fri 11 Jul 2008 06:12:14 PM UTC, comment #7:

Ok. Thanks. I'll try to take a look when my exams are over.

Sascha Sommer <faust3>
Project Administrator
Wed 02 Jul 2008 10:41:12 PM UTC, comment #6:

Well, and I'm not the issue reporter :-)

Andrew Gaydenko

Anonymous
Wed 02 Jul 2008 07:45:34 PM UTC, comment #5:

Sascha,

I don't remeber needed diff options :-) - it is simpler to show both whole methods. I'm on Gentoo/Linux.

Andrew Gaydenko

===========================
/* return current volume [0-100] */
static float player_get_volume(player_t* player){
yauap_priv_t* priv = player->yauap_priv;
gdouble volume = 0.0;
/* get current volume */
if(priv->volume)
g_object_get( G_OBJECT(priv->volume), "volume", &volume, NULL );
//!! return volume * 25.0;
return volume * 100.0;
}

/* set new volume [0-100] */
static int player_set_volume(player_t* player,float value){
yauap_priv_t* priv = player->yauap_priv;
gdouble volume = value;

priv->cur_volume = value;

if(!priv->volume)
return TRUE;

/* change range from 0 - 100 to 0 - 4 */
//!! volume *= 0.04;
volume *= 0.01;

/* ajust values */
if(volume < 0.0)
volume = 0.0;
//!! else if(volume > 4.0)
//!! volume = 4.0;
else if(volume > 1.0)
volume = 1.0;

printf("\nsetting volume %f\n",value);
g_object_set(G_OBJECT(priv->volume), "volume", volume, NULL);
return TRUE;
}

Anonymous
Wed 02 Jul 2008 02:39:30 PM UTC, comment #4:

Does this only happen with that old version of openSUSE?

The volume control seems to be correct for me with openSUSE 10.3

Also please post a full patch containing all your changes.

Sascha Sommer <faust3>
Project Administrator
Sun 22 Jun 2008 03:05:54 PM UTC, comment #3:

Well, also in player_get_volume last string was replaced with

return volume * 100.0;

Anonymous
Wed 28 May 2008 03:29:35 AM UTC, comment #2:

I have replaced all '4' symbols with '1' in main.c player_set_volume() - also using amarok :-)

Anonymous
Sun 20 Apr 2008 12:45:00 PM UTC, comment #1:

Does this also happen when playing ogg or wav files? Did you try other GStreamer apps?

Sascha Sommer <faust3>
Project Administrator
Fri 18 Apr 2008 09:15:26 PM UTC, original submission:

amarok-1.4.7-61.2 ~/repositories/KDE:/Backports/
amarok-yauap-1.4.7-61.2 ~/repositories/KDE:/Backports/
yauap-0.2.1-21 ~/repositories/GPhoto/
gst-fluendo-mp3-2-7 ~/distribution/10.3/repo/src-non-oss/
w/ fluendo-mp3-3.i386.tar.bz2

Linux 2.6.18.8-0.9-default i686
3.5.5 "release 45.8"
openSUSE 10.2 (i586)

sound distortion when adjusting amarok's volume
on MP3 file

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by faust3 (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 05 Oct 2008 06:54:25 PM UTCfaust3Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1