bugThe nmh Mail Handling System - Bugs: bug #23163, Restore build functionality lost...

 
 

bug #23163: Restore build functionality lost sometime since nmh-1.0.4

Submitted by:  Russell Ruby <redneckruss>
Submitted on:  Sun 04 May 2008 09:24:32 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: NoneOpen/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 04 May 2008 04:19:38 PM UTC, comment #1:

Thanks for this patch. I've applied it to CVS (trunk, and the 1.3 branch as soon as I've tested it there), and it should be in 1.3 proper when it gets released.

PS: you missed a couple of things:
(a) listing the new memmove.c in COMPAT in sbr/Makefile.in
(b) the $(LEX) invocation in sbr/Makefile.in also needed an explict filename changing to a $<

Peter Maydell <pm215>
Project Administrator
Sun 04 May 2008 09:24:32 AM UTC, original submission:

Two broken capabilities:

1). Somewhere along the way since nmh-1.0.4, some Makefile "$<" automatic
variable were changed to absolute names, breaking the ability to build
in a directory outside the nmh distribution "top src" directory.
See section 4.5.4 of the GNU make manual.
http://www.gnu.org/software/make/manual/make.html
The attached patch corrects this problem.

2). nmh-1.0.4 could automatically provide substitutions for missing
library functions. This functionality was also broken since nmh-1.0.4.
The included patch restores this capablitity, plus restores one function
"strerror.c" removed from the sbr directory sometime since nmh-1.0.4
(the copy from nmh-1.0.4 is provided with the patch) and it adds an
additional missing library function "memmove" which appeared in nmh
since nmh-1.0.4. Rather than use one of my versions of memmove.c,
the patch includes one found on Jan Wolter's "Unix Incompatibility Notes"
web page, "http://unixpapa.com/incnote/".

My own hack to get nmh-1.3-RC1 working was to simply use a macro
redefinition using "bcopy", but seems best to be more general for a
patch submission. This also required a tiny update to configure.in
to include memmove and restore strerror to the list of missing
function tests.

thanks for all the good work,

russell ruby

Russell Ruby <redneckruss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15602:  config_make_functions.patch added by redneckruss (2KiB - application/octet-stream - configure.in, config/Makefile.in, sbr/Makefile.in, plus function corrections)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pm215 (Posted a comment)
  • -unavailable- added by redneckruss (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 04 May 2008 04:19:38 PM UTCpm215StatusNone=>Fixed
      Open/ClosedOpen=>Closed
    Sun 04 May 2008 09:24:32 AM UTCredneckrussAttached File-=>Added config_make_functions.patch, #15602

    Back to the top


    Powered by Savane 3.1-cleanup1