bugGlobulation 2 - Bugs: bug #23501, clicking on toolbar builds a...

 
 

bug #23501: clicking on toolbar builds a building

Submitted by:  None
Submitted on:  Fri 06 Jun 2008 12:34:00 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Bradley Arsenault <genixpro>Open/Closed: Closed
Release: mercurialOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 15 Jun 2008 10:56:34 AM UTC, comment #4:

Nuage and I fixed it in latest mercurial

Stephane Magnenat <nct>
Project Administrator
Thu 12 Jun 2008 02:43:08 PM UTC, comment #3:

This bug was introduced in changeset 3593. Before, building was placed when mouse button was pressed and GameGUIToolManager::handleMouseUp did essentialy nothing. After that change, building is placed when mouse button is released, which is done in GameGUIToolManager::handleMouseUp. So we must think twice before calling it (which is what my patch bugfix2.patch does).

Marek Jancuska

Anonymous
Mon 09 Jun 2008 07:11:32 PM UTC, comment #2:

so we should also check whether the released mouse button is left button.

Anonymous
Sat 07 Jun 2008 12:44:56 PM UTC, comment #1:

Even worse :)
1st: I can confirm this.
2nd: if you got this virtual building sticking to your mouse pointer and use the mmb-navigation you place a new building with every mouse release.

The patch:
Thanx for debugging and providing a hotfix. As the patch does not restore the intended behaviour, we will have to see what introduced this bug.

Leo Wandersleb <giszmo>
Project Member
Fri 06 Jun 2008 12:34:00 PM UTC, original submission:

I have a toolbar with list of building displayed. When I click on a buiding icon on a toolbar, two things happen:
(1) appropriate building type is selected
(2) building of this type is built. It is placed behind the toolbar, as if the toolbar wasn't there.
Only (1) should occur.

My debugging has shown that (1) occurs when processing SDL_MOUSEBUTTONDOWN and (2) occurs when processing SDL_MOUSEBUTTONUP.

The offending line is GameGUI.cpp:965. No test is done whether mouse position is withing the toolbar.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #15826:  bugfix2.patch added by None (579B - text/x-diff - this solves releasing mmb)
file #15804:  bugfix.patch added by None (757B - text/x-diff - this patch solves the problem)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nct (Posted a comment)
  • -unavailable- added by giszmo (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 15 Jun 2008 10:56:34 AM UTCnctOpen/ClosedOpen=>Closed
    Sun 15 Jun 2008 10:56:33 AM UTCnctStatusConfirmed=>Fixed
    Mon 09 Jun 2008 07:08:22 PM UTCNoneAttached File-=>Added bugfix2.patch, #15826
    Sat 07 Jun 2008 12:44:56 PM UTCgiszmoStatusNone=>Confirmed
      Assigned toNone=>genixpro
    Fri 06 Jun 2008 03:49:08 PM UTCNoneAttached File-=>Added bugfix.patch, #15804

    Back to the top


    Powered by Savane 3.1-cleanup1