bugGlobulation 2 - Bugs: bug #23800, infinite loop in...

 
 

bug #23800: infinite loop in NewNicowar::compute_defense_flag_positioning

Submitted by:  None
Submitted on:  Tue 08 Jul 2008 12:14:37 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: mercurialOperating System: GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 06 Jan 2009 04:37:23 PM UTC, comment #3:

I have commit in the patch.

Bradley Arsenault <genixpro>
Project Administrator
Tue 08 Jul 2008 04:50:46 PM UTC, comment #2:

my solution is attached as bugfix3.patch

Marek Jancuska

Anonymous
Tue 08 Jul 2008 04:05:02 PM UTC, comment #1:

This is caused by a unit with posX=-1 (and posY=100 and gid=2091). When manipulating unitGID array in NewNicowar::compute_defense_flag_positioning, we do
unitGID[unit->posX * h + unit->posY] = unit->gid;
but the index evaluates to -28 (h=128).

The offending unit's last movement is entering a building.
Unit::handleAction:
...
case MOV_ENTERING_BUILDING:
{
...
posX+=dx;
posY+=dy;
This is the point (Unit.cpp:2091) where posX becomes -1. No adjustment is made later.

Anonymous
Tue 08 Jul 2008 12:14:37 PM UTC, original submission:

Loading the attached savegame causes glob2 to freeze after few seconds.
Glob2 enters an infinite cycle
while(!locations.empty()) {...}

The problem is that there are no units or buildings near the selected location. So modify_points isn't called, and locations doesn't change.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16032:  bugfix3.patch added by None (560B - text/x-diff)
file #16030:  bug-maybe2.game.bz2 added by None (45KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by nct (Updated the item)
  • -unavailable- added by genixpro (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 16 Aug 2009 11:57:43 AM UTCnctOpen/ClosedOpen=>Closed
    Mon 28 Jul 2008 07:29:08 PM UTCgenixproStatusNone=>Fixed
    Tue 08 Jul 2008 04:47:53 PM UTCNoneAttached File-=>Added bugfix3.patch, #16032
    Tue 08 Jul 2008 12:16:31 PM UTCNoneAttached File-=>Added bug-maybe2.game.bz2, #16030

    Back to the top


    Powered by Savane 3.1-cleanup1