bugThe FreeType Project - Bugs: bug #24179, Default values for multiple master...

 
 

bug #24179: Default values for multiple master design axis are not correct.

Submitted by:  bram tassyns <bramt>
Submitted on:  Mon 01 Sep 2008 01:35:59 PM UTC  
 
Severity: 3 - NormalItem Group: Incorrect behaviour
Status: FixedPrivacy: Public
Assigned to: Werner LEMBERG <wl>Open/Closed: Closed
Planned Release: 2.3.8

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 15 Sep 2008 07:48:53 AM UTC, comment #3:

This is now in the CVS. Thanks for testing.

Werner LEMBERG <wl>
Project AdministratorIn charge of this item.
Tue 09 Sep 2008 11:46:12 AM UTC, comment #2:

With the attached patch applied everything seems to work fine.

Thnx

bram tassyns <bramt>
Mon 08 Sep 2008 11:12:53 PM UTC, comment #1:

I believe you are correct. Your patch fixes about half the bug, the "side question" is the other half of the bug. The attached patch includes yours and should fix the full problem.

(file #16454)

Anonymous
Mon 01 Sep 2008 01:35:59 PM UTC, original submission:

If a WeigthVector is present the default values for the axis are not calculated correctly, they are shifted an additional 16 bits. I encountered this issue when processing TektonMM with the default values given by freetype (they were outside the min/max range).

Proposed fix:

t1load.c, T1_Get_MM_Var:

for ( i = 0; i < mmaster.num_axis; ++i )
mmvar->axis[i].def =
FT_INT_TO_FIXED( mm_axis_unmap( &blend->design_map[i],
axiscoords[i] ) );

=>

for ( i = 0; i < mmaster.num_axis; ++i )
mmvar->axis[i].def = mm_axis_unmap( &blend->design_map[i],
axiscoords[i] );

As a side question, how are the default values generated from the WeightVector ? I assumed that when you use the default values you'll get the same WeightVector internally (ignoring rounding errors). I would have liked to retrieve the design axis values of the standard weight vector but those returned by freetype don't match.

bram tassyns <bramt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16454:  mm.patch added by None (949B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by bramt (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 15 Sep 2008 07:48:53 AM UTCwlStatusNone=>Fixed
      Assigned toNone=>wl
      Open/ClosedOpen=>Closed
      Planned ReleaseNone=>2.3.8
    Mon 08 Sep 2008 11:12:53 PM UTCNoneAttached File-=>Added mm.patch, #16454

    Back to the top


    Powered by Savane 3.1-cleanup1