bugrdiff-backup - Bugs: bug #24192, Allow --exclude-if-present to work...

 
 

bug #24192: Allow --exclude-if-present to work with directories

Submitted by:  Vadim Zeitlin <zeitlin>
Submitted on:  Tue 02 Sep 2008 11:43:01 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 04 Sep 2008 11:30:11 PM UTC, comment #1:

Hi Vadim,

Good suggestion. I am going to change .isreg() at the end to .lstat() which will simply check if the path exists. It can be a dir, file, symlink, device, etc.

I would appreciate if you could test the change (if you're comfortable editing python, which I assume is the case).

Thanks,
Andrew

Andrew Ferguson <owsla>
Project Administrator
Tue 02 Sep 2008 11:43:01 PM UTC, original submission:

Currently the implementation of this option explicitly checks that its argument is a regular file, see presence_get_sf function in selection.py:

But I'd like to use it with directories to exclude backup of CVS and svn checkouts, e.g. --exclude-if-present=.svn. Would it be possible to relax this check to also work with directories?

Thanks in advance!

Vadim Zeitlin <zeitlin>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by owsla (Posted a comment)
  • -unavailable- added by zeitlin (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 04 Sep 2008 11:30:11 PM UTCowslaStatusNone=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1