bugLordsAWar! - Bugs: bug #24193, Allies stuck in the mountains

 
 

bug #24193: Allies stuck in the mountains

Submitted by:  None
Submitted on:  Wed 03 Sep 2008 05:36:18 AM UTC  
 
Category: gameSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 04 Sep 2008 12:46:04 AM UTC, comment #2:

Getting allies as a reward will no longer be placed on mountains, unless they happen to be able to fly.

I had code already in place to handle this special case, but it was faulty.

Fixing with this:
--- GameMap.cpp (revision 1561)
+++ GameMap.cpp (working copy)
@@ -415,8 +415,7 @@
if (!land && getTile(x, y)->getType() != Tile::WATER)
continue;
if (land && getTile(x, y)->getType() == Tile::MOUNTAIN &&
- (a->getStat(Army::MOVE_BONUS) & Tile::MOUNTAIN) ==
- Tile::MOUNTAIN)
+ (a->getStat(Army::MOVE_BONUS) & Tile::MOUNTAIN) == 0)
continue;
//is there somebody else's stack here?
s = Stacklist::getObjectAt(x, y);

As you can see, the army's move bonus was erronesouly checked to see if it contained the ability to go on mountains -- when it should have been checking for the inability to go on mountains.

Fixed in svn. Thanks for the bug report.

Ben Asselstine <benasselstine>
Project Administrator
Thu 04 Sep 2008 12:25:28 AM UTC, comment #1:

Can you tell me what version of LordsAWar this happened with?

Ben Asselstine <benasselstine>
Project Administrator
Wed 03 Sep 2008 05:36:18 AM UTC, original submission:

When a hero is given some allies that don't fit into his stack the allies appear in the adjacent tiles. It doesn't take into account that the adjacent tile can be a mountain where certain kinds of of the allies can't move and can place them in the mountains. This way the allies that can't move in the mountains get stuck in the mountains.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16422:  Stuck_Allies.png added by None (125KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by benasselstine (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 04 Sep 2008 12:46:04 AM UTCbenasselstineOpen/ClosedOpen=>Closed
    Wed 03 Sep 2008 05:36:18 AM UTCNoneAttached File-=>Added Stuck_Allies.png, #16422

    Back to the top


    Powered by Savane 3.1-cleanup1