bugCERTI - Bugs: bug #24294, crash after...

 
 

bug #24294: crash after MessageBuffer::read/write_...s() with zero length

Submitted by:  Petr Gotthard <gotthardp>
Submitted on:  Thu 18 Sep 2008 09:21:23 AM UTC  
 
Category: CERTISeverity: 4 - Important
Item Group: Software errorStatus: Ready For Test
Privacy: PublicAssigned to: Petr Gotthard <gotthardp>
Open/Closed: ClosedRelease: CVS
Reproducibility: Every TimeFixed Release: 3.3.1

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 18 Sep 2008 02:43:43 PM UTC, comment #2:

Fixed.

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Thu 18 Sep 2008 10:28:55 AM UTC, comment #1:

I think yes we should:

data[0] may be replaced by:

data==NULL ? 0 : data[0]

concerning performance you are right,
but in debug the first data is insightful :=)

I think that debugging output should be suppressed
alltogether when not compiling in debug mode.
Current "PrettyPrinter" class is not made like this
but we may change this in the future
in order to have better performance for CERTI
compiled for "Release".

Eric NOULARD <erk>
Project Administrator
Thu 18 Sep 2008 09:21:23 AM UTC, original submission:

The read/write_...s functions have a debug output that print first element in the field that has been saved/loaded (data[0]). If the list is empty (len=0) this may cause segmentation fault.

Should we add a condition (that affects the performance) or stop printing first element?

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by erk (Posted a comment)
  • -unavailable- added by gotthardp (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 21 Sep 2008 10:55:47 AM UTCerkOpen/ClosedOpen=>Closed
      Fixed ReleaseUnknown=>3.3.1
    Thu 18 Sep 2008 02:43:43 PM UTCgotthardpStatusNone=>Ready For Test
      Assigned toNone=>gotthardp

    Back to the top


    Powered by Savane 3.1-cleanup1