bugLordsAWar! - Bugs: bug #24386, Fixed some compile warnings...

 
 

bug #24386: Fixed some compile warnings (svn1619)

Submitted by:  None
Submitted on:  Sat 27 Sep 2008 11:33:57 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 27 Sep 2008 01:48:00 PM UTC, comment #2:

Thanks. Added to svn.

Would you care to try your hand at hacking up a patch for one of the tasks in the task tracker?

Ben Asselstine <benasselstine>
Project Administrator
Sat 27 Sep 2008 11:40:49 AM UTC, comment #1:

I just recognized, that there is something similar in lines 337/338, which are commented out.

Anonymous
Sat 27 Sep 2008 11:33:57 AM UTC, original submission:

Hi Ben,

I fixed some compile warnings, s. "diff.txt".

Last remaining warning is:
vectormap.cpp:392: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false

I didn't try to fix it, because I don't sufficiently understand the code. But I think, the condition
dest.x >= dest.x - dist
in line 392 means just
0 >= -4
which is always true. This makes no sense to me.

You like to check this? ;-)

Greetings

Balemo

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16575:  diff.txt added by None (3KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by benasselstine (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 27 Sep 2008 01:48:00 PM UTCbenasselstineOpen/ClosedOpen=>Closed
    Sat 27 Sep 2008 11:33:57 AM UTCNoneAttached File-=>Added diff.txt, #16575

    Back to the top


    Powered by Savane 3.1-cleanup1