bugTransport Sample Protocol - Bugs: bug #24593, pkgconfig path issue when using...

 
 

bug #24593: pkgconfig path issue when using target tsp_rpm

Submitted by:  Olivier BONHOMME <ptitoliv>
Submitted on:  Fri 17 Oct 2008 11:49:48 AM UTC  
 
Category:  Packaging Severity:  3 - Normal
Status:  Need Info Privacy:  Public
Assigned to:  Eric NOULARD <erk> Open/Closed:  Open
Release:  0.8.3 Fixed Release:  CVS

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 23 Dec 2008 03:27:16 PM UTC, comment #9: 

Bug corrected considering UseRPMTool with the patch #6656

Olivier BONHOMME <ptitoliv>
Project Member
Wed 12 Nov 2008 02:27:17 PM UTC, comment #8: 

Nope.

Current CPack RPM generator does generate another spec file.

It should work with hand-crafted spec file
as the one use with UseRPMTools
(the one which generate tsp_rpm and tsp_srpm)

If you want more infos on difference between
UseRPMTools and CPack RPM generator please
have a look at:
http://www.cmake.org/Wiki/CMake:CPackPackageGenerators#RPM_.28Unix_Only.29

There remain some work for CPack RPM generator to
work just like UseRPMTools.

Unfortunately I have not much time those days to work on this.
My advice for your use case would be:

 - try to patch tsp/src/scripts/tsp.spec.in
   and/or  make/UseRPMTools.cmake
   in order to make them work as you want

 - send me an e-mail describing your need for may be
   next release of CPack RPM
   and/or provide a patch and/or open a bug report
   in the CMake bug tracker for CPack RPM.

Eric NOULARD <erk>
Project AdministratorIn charge of this item.
Wed 12 Nov 2008 02:06:22 PM UTC, comment #7: 

Hello,

I have the same behaviour considering using the CPACK_SET_DESTDIR variable. The tsp.pc file is in the /opt/scripts directory and not moved to /usr/lib/pkgconfig.

Does the cpack command executes shells commands located in the install block of the spec file ?

Olivier BONHOMME <ptitoliv>
Project Member
Fri 07 Nov 2008 10:37:43 PM UTC, comment #6: 

I know the reason of your error,
you should use:

cpack -D CPACK_SET_DESTDIR=ON -G RPM
or
SET(CPACK_SET_DESTDIR ON) in tsp/CMakeLists.txt

see
http://public.kitware.com/Bug/view.php?id=7000

sorry for the delay but I did not have this bug
because I use a patched CMake version...

Eric NOULARD <erk>
Project AdministratorIn charge of this item.
Mon 20 Oct 2008 12:04:39 PM UTC, comment #5: 

I downloaded the last sources from CVS tagged TSP_0_8_3.

If I use the way cmake -DCMAKE_INSTALL_PREFIX=/opt and cpack -G RPM, the rpm generated contains files with /usr as prefix and not the directory I specified.

The tsp.pc file contains the good prefix (/opt) but it is not installed in the /usr/lib/pkgconfig directory.

Olivier BONHOMME <ptitoliv>
Project Member
Sat 18 Oct 2008 01:07:40 PM UTC, comment #4: 

With the current CVS version,
if you run

cmake -DCMAKE_INSTALL_PREFIX=/opt
then
make
cpack -G RPM
you should have a clean RPM content regarding tsp.pc
(cpack -G RPM needs CMake 2.6.x in order to be available)

Note that if you don't specify CMAKE_INSTALL_PREFIX
then the default value is /usr.

Now if you do use:
make tsp_rpm  (and not cpack -G RPM)
then I have an unidentified trouble...

Eric NOULARD <erk>
Project AdministratorIn charge of this item.
Fri 17 Oct 2008 02:10:21 PM UTC, comment #3: 

You probably don't want to use plain 0.8.3, you should use the cvs version instead.
CVS contains fixes for the BB needed for dadi and the in-kernel BB.

Frederik Deweerdt <deweerdt>
Project Administrator
Fri 17 Oct 2008 02:07:04 PM UTC, comment #2: 

I noticed the bug using the sources located at this URL :

http://download.savannah.gnu.org/releases/tsp/tsp-0.8.x/tsp-0.8.3/sources/tsp-0.8.3-Source.tar.gz

With theses sources, the tsp.pc file is generated using the macro CMAKE_INSTALL_PREFIX which gives the result that I reported opening the ticket. I think there is a gap between the CVS and the repo.

Considering your comment, I replaced the tsp.pc.in file by the one you told me.

With this version the tsp.pc is generated with an empty value for the prefix. Is there a specific parameter to use with cmake in order to intialize the macro ?

Olivier BONHOMME <ptitoliv>
Project Member
Fri 17 Oct 2008 01:10:07 PM UTC, comment #1: 

It should already be fixe in CVS.

Would you try to replace your 0.8.3
tsp/src/scripts/tsp.pc.in
file with the one found in CVS HEAD ?

http://cvs.savannah.gnu.org/viewvc/*checkout*/tsp/src/scripts/tsp.pc.in?root=tsp

Eric NOULARD <erk>
Project AdministratorIn charge of this item.
Fri 17 Oct 2008 11:49:48 AM UTC, original submission:  

The prefix path contained in the generated tsp.pc file when the RPM for tsp built is incorrect.

It should be the target directory on the system where the RPM is installed in stead of being the RPM environment build directory.

tsp.pc snapshot generated with tsp_rpm target
----------------------------------------------

prefix=/home/olivier/tsp/tsp_build/RPM/tmp/opt/tsp-0.8.3
exec_prefix=/home/olivier/tsp/tsp_build/RPM/tmp/opt/tsp-0.8.3/bin
libdir=/home/olivier/tsp/tsp_build/RPM/tmp/opt/tsp-0.8.3/lib
includedir=/home/olivier/tsp/tsp_build/RPM/tmp/opt/tsp-0.8.3/incl

The prefix should be /opt/tsp-0.8.3 and not /home/olivier/tsp/tsp_build/RPM/tmp/opt/tsp-0.8.3.

Olivier BONHOMME <ptitoliv>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by deweerdt (Posted a comment)
  • -email is unavailable- added by erk (Posted a comment)
  • -email is unavailable- added by ptitoliv (Submitted the item)
  • -email is unavailable- added by ptitoliv
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-10-17 erk Fixed ReleaseUnknown => CVS
    2008-10-17 erk StatusNone => Need Info
        Assigned toNone => erk
    2008-10-17 ptitoliv Carbon-Copy- => Added obonhomme@nerim.net

    Back to the top


    Powered by Savane 3.5