bugThe eXtended osip library - Bugs: bug #24805, ...

 
 

bug #24805: jresponse.c:complete_answer_that_establish_a_dialog needs to initialize firewall_ip and firewall_port

Submitted by:  None
Submitted on:  Mon 10 Nov 2008 09:41:53 PM UTC  
 
Category: NoneSeverity: 2 - Minor
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Aymeric MOIZARD <aymeric>
Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 11 Nov 2008 10:46:27 AM UTC, comment #1:

I have added the change and also added the same fix everywhere similar code is called.

However, all current implementation always provide this method AND must always return a valid firewall_port by design. This is why this code was not needed.

Aymeric

Aymeric MOIZARD <aymeric>
Project AdministratorIn charge of this item.
Mon 10 Nov 2008 09:41:53 PM UTC, original submission:

Since the eXosip->tl_get_masquerade_contact function is optional, the code can't assume that firewall_ip and firewall_port are going to be initialized.

      • jresponse.c Fri Oct 26 05:57:24 2007

--- jresponse.c.new Mon Nov 10 13:40:31 2008
***************

      • 171,176 ****

--- 171,178 ----
char locip[65];
char firewall_ip[65];
char firewall_port[10];
+ memset(firewall_ip, 0, sizeof(firewall_ip));
+ memset(firewall_port, 0, sizeof(firewall_port));
if (eXosip.eXtl->tl_get_masquerade_contact!=NULL)
{
eXosip.eXtl->tl_get_masquerade_contact(firewall_ip, sizeof(firewall_ip),

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by aymeric (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 11 Nov 2008 10:46:27 AM UTCaymericSeverity3 - Normal=>2 - Minor
      StatusNone=>Fixed
      Assigned toNone=>aymeric
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1